[Groonga-commit] groonga/grnxx at 9ffd3c3 [new_data_types] Remove comments.

Back to archive index

susumu.yata null+****@clear*****
Mon Nov 17 10:40:44 JST 2014


susumu.yata	2014-11-17 10:40:44 +0900 (Mon, 17 Nov 2014)

  New Revision: 9ffd3c3485957f006fd9338be88d948d774d2bc5
  https://github.com/groonga/grnxx/commit/9ffd3c3485957f006fd9338be88d948d774d2bc5

  Message:
    Remove comments.

  Modified files:
    lib/grnxx/impl/expression.cpp

  Modified: lib/grnxx/impl/expression.cpp (+0 -22)
===================================================================
--- lib/grnxx/impl/expression.cpp    2014-11-17 10:09:08 +0900 (5bc00fd)
+++ lib/grnxx/impl/expression.cpp    2014-11-17 10:40:44 +0900 (73d187c)
@@ -59,16 +59,6 @@ class TypedNode : public Node {
     return T::type();
   }
 
-//  void filter(ArrayCRef<Record>, ArrayRef<Record> *) {
-//    // Other than TypedNode<Bool> don't support filter().
-//    throw "Not supported";
-//  }
-
-//  void adjust(ArrayRef<Record>) {
-//    // Other than TypedNode<Float> don't support adjust().
-//    throw "Not supported";
-//  }
-
   // Evaluate the expression subtree.
   //
   // The evaluation results are stored into "*results".
@@ -96,12 +86,6 @@ class TypedNode<Bool> : public Node {
   virtual void filter(ArrayCRef<Record> input_records,
                       ArrayRef<Record> *output_records);
 
-//  void adjust(ArrayRef<Record>) {
-//    // Other than TypedNode<Float> don't support adjust().
-//    GRNXX_ERROR_SET(error, INVALID_OPERATION, "Invalid operation");
-//    return false;
-//  }
-
   virtual void evaluate(ArrayCRef<Record> records,
                         ArrayRef<Value> results) = 0;
 
@@ -137,12 +121,6 @@ class TypedNode<Float> : public Node {
     return Value::type();
   }
 
-//  void filter(ArrayCRef<Record>, ArrayRef<Record> *) {
-//    // Other than TypedNode<Bool> don't support filter().
-//    GRNXX_ERROR_SET(error, INVALID_OPERATION, "Invalid operation");
-//    return false;
-//  }
-
   // NOTE: Derived classes should provide better implementations.
   virtual void adjust(ArrayRef<Record> records);
 
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Back to archive index