[Groonga-commit] groonga/groonga at f1534b3 [master] range_filter: fix a bug that error message isn't shown

Back to archive index

Kouhei Sutou null+****@clear*****
Wed Nov 19 19:02:42 JST 2014


Kouhei Sutou	2014-11-19 19:02:42 +0900 (Wed, 19 Nov 2014)

  New Revision: f1534b345d192ce37ffd1f4c416162d968793320
  https://github.com/groonga/groonga/commit/f1534b345d192ce37ffd1f4c416162d968793320

  Message:
    range_filter: fix a bug that error message isn't shown

  Modified files:
    lib/proc.c
    test/command/suite/range_filter/limit/invalid_format.expected

  Modified: lib/proc.c (+1 -0)
===================================================================
--- lib/proc.c    2014-11-19 18:48:21 +0900 (0fcd5c8)
+++ lib/proc.c    2014-11-19 19:02:42 +0900 (1882564)
@@ -6211,6 +6211,7 @@ proc_range_filter(grn_ctx *ctx, int nargs, grn_obj **args,
           "[range_filter] invalid limit format: <%.*s>",
           (int)GRN_TEXT_LEN(limit), GRN_TEXT_VALUE(limit));
       GRN_OBJ_FIN(ctx, &int32_value);
+      goto exit;
     }
     real_limit = GRN_INT32_VALUE(&int32_value);
 

  Modified: test/command/suite/range_filter/limit/invalid_format.expected (+1 -1)
===================================================================
--- test/command/suite/range_filter/limit/invalid_format.expected    2014-11-19 18:48:21 +0900 (7467563)
+++ test/command/suite/range_filter/limit/invalid_format.expected    2014-11-19 19:02:42 +0900 (1f17098)
@@ -9,5 +9,5 @@ table_create IDs TABLE_PAT_KEY Int32
 column_create IDs memos_id COLUMN_INDEX Memos id
 [[0,0.0,0.0],true]
 range_filter Memos id --limit x
-[[0,0.0,0.0],[[]]]
+[[[-22,0.0,0.0],"[range_filter] invalid limit format: <x>"]]
 #|e| [range_filter] invalid limit format: <x>
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Back to archive index