HAYASHI Kentaro
hayas****@clear*****
Fri Sep 5 15:24:15 JST 2014
On Thu, 04 Sep 2014 02:43:49 +0900 long-long-float <null+****@clear*****> wrote: > long-long-float 2014-09-04 02:43:49 +0900 (Thu, 04 Sep 2014) > > New Revision: 87e9564aed17f13b6a6ceddddfceb35f27a7e8a6 > https://github.com/long-long-float/droonga-engine/commit/87e9564aed17f13b6a6ceddddfceb35f27a7e8a6 > > Merged e1158cd: Merge pull request #23 from long-long-float/safer-install-script > > Message: > Fixed usage of [ > > Modified files: > script/install.sh > > Modified: script/install.sh (+5 -5) > =================================================================== > --- script/install.sh 2014-09-04 02:03:30 +0900 (742ce5f) > +++ script/install.sh 2014-09-04 02:43:49 +0900 (d176f0d) > @@ -6,7 +6,7 @@ > apt-get update > apt-get -y upgrade > apt-get install -y ruby ruby-dev build-essential > -gem install droonga-engine > +gem install droonga-engine --no-rdoc --no-ri > > SCRIPT_URL=https://raw.githubusercontent.com/droonga/droonga-engine/master/script > USER=droonga-engine > @@ -19,15 +19,15 @@ exist_user() { > # add droonga-engine user and create files > exist_user $USER || useradd -m $USER > > -[ ! $DROONGA_BASE_DIR ] && > +[ ! -e $DROONGA_BASE_DIR ] && > mkdir $DROONGA_BASE_DIR ここではディレクトリの有無をチェックしたいので、-dのほうがよいと思いました。 -- HAYASHI Kentaro <hayas****@clear*****>
