[Groonga-commit] groonga/grnxx at d48182a [master] Remove Column::create_cursor() because it is not used.

Back to archive index

susumu.yata null+****@clear*****
Fri Sep 19 09:35:15 JST 2014


susumu.yata	2014-09-19 09:35:15 +0900 (Fri, 19 Sep 2014)

  New Revision: d48182aa2f7b6ebb6c6cc83958b8fa57529412c0
  https://github.com/groonga/grnxx/commit/d48182aa2f7b6ebb6c6cc83958b8fa57529412c0

  Message:
    Remove Column::create_cursor() because it is not used.

  Modified files:
    include/grnxx/column.hpp
    lib/grnxx/column.cpp

  Modified: include/grnxx/column.hpp (+0 -9)
===================================================================
--- include/grnxx/column.hpp    2014-09-18 16:14:18 +0900 (1951b1b)
+++ include/grnxx/column.hpp    2014-09-19 09:35:15 +0900 (30b9f40)
@@ -114,15 +114,6 @@ class Column {
   // "error" != nullptr.
   virtual bool get(Error *error, Int row_id, Datum *datum) const;
 
-  // Create a cursor to get records.
-  //
-  // On success, returns a pointer to the cursor.
-  // On failure, returns nullptr and stores error information into "*error" if
-  // "error" != nullptr.
-  virtual unique_ptr<Cursor> create_cursor(
-      Error *error,
-      const CursorOptions &options = CursorOptions()) const;
-
  protected:
   Table *table_;
   Name name_;

  Modified: lib/grnxx/column.cpp (+0 -8)
===================================================================
--- lib/grnxx/column.cpp    2014-09-18 16:14:18 +0900 (468633c)
+++ lib/grnxx/column.cpp    2014-09-19 09:35:15 +0900 (039da1b)
@@ -114,14 +114,6 @@ bool Column::get(Error *error, Int, Datum *) const {
   return false;
 }
 
-unique_ptr<Cursor> Column::create_cursor(
-    Error *error,
-    const CursorOptions &) const {
-  // TODO: Cursor is not supported yet.
-  GRNXX_ERROR_SET(error, NOT_SUPPORTED_YET, "Not suported yet");
-  return nullptr;
-}
-
 unique_ptr<Column> Column::create(Error *error,
                                   Table *table,
                                   String name,
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Back to archive index