[Groonga-commit] droonga/droonga-engine at 1a6d3eb [master] Add TODO comment for the future

Back to archive index

YUKI Hiroshi null+****@clear*****
Fri Apr 17 16:10:28 JST 2015


YUKI Hiroshi	2015-04-17 16:10:28 +0900 (Fri, 17 Apr 2015)

  New Revision: 1a6d3eb8fa69e219e00540eed4c51b518dfdb756
  https://github.com/droonga/droonga-engine/commit/1a6d3eb8fa69e219e00540eed4c51b518dfdb756

  Message:
    Add TODO comment for the future

  Modified files:
    lib/droonga/session.rb

  Modified: lib/droonga/session.rb (+15 -0)
===================================================================
--- lib/droonga/session.rb    2015-04-17 16:02:36 +0900 (dad05ef)
+++ lib/droonga/session.rb    2015-04-17 16:10:28 +0900 (cd42b80)
@@ -35,6 +35,21 @@ module Droonga
       @n_dones ==****@tasks*****
     end
 
+    #TODO: We don't have to wait results if no collection step is
+    #      in the list of tasks, because:
+    #
+    #       * Currently the "super step" mecahnism is not
+    #         implemented yet.
+    #       * So, results won't be used by other handlers directly.
+    #         Results will be used only for the "response" for the
+    #         sender.
+    #       * So, if there is no collection step, no-one requires
+    #         results and there is no need to wait results.
+    #
+    #      However, in the future after the "super step" mechanism
+    #      is introduced, results can be used by other handlers
+    #      even if there is no collection step.
+    #      Then we must update this logic.
     def need_result?
       @tasks.any? do |task|
         @collector_runner.collectable?("task" => task)
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Back to archive index