YUKI Hiroshi
null+****@clear*****
Thu Apr 30 11:42:36 JST 2015
YUKI Hiroshi 2015-04-30 11:42:36 +0900 (Thu, 30 Apr 2015) New Revision: 16ef4d07d1961310b2069e9bdc9ca2e17f3e753c https://github.com/droonga/droonga-engine/commit/16ef4d07d1961310b2069e9bdc9ca2e17f3e753c Message: Use named parameters instead of confusable list of arguments Modified files: lib/droonga/command/droonga_engine_service.rb lib/droonga/engine.rb Modified: lib/droonga/command/droonga_engine_service.rb (+5 -2) =================================================================== --- lib/droonga/command/droonga_engine_service.rb 2015-04-30 11:40:23 +0900 (9180e7e) +++ lib/droonga/command/droonga_engine_service.rb 2015-04-30 11:42:36 +0900 (6507173) @@ -157,8 +157,11 @@ module Droonga end def run_engine - @engine = Engine.new(@loop, @engine_name, @internal_engine_name, - :internal_connection_lifetime => @internal_connection_lifetime) + @engine = Engine.new(:loop => @loop, + :name => @engine_name, + :internal_name => @internal_engine_name, + :internal_connection_lifetime => + @internal_connection_lifetime) @engine.on_ready = lambda do @worker_process_agent.ready end Modified: lib/droonga/engine.rb (+6 -6) =================================================================== --- lib/droonga/engine.rb 2015-04-30 11:40:23 +0900 (de15685) +++ lib/droonga/engine.rb 2015-04-30 11:42:36 +0900 (7c870ee) @@ -36,21 +36,21 @@ module Droonga attr_reader :cluster - def initialize(loop, name, internal_name, options={}) - @name = name - @internal_name = internal_name - @loop = loop + def initialize(params={}) + @name = params[:name] + @internal_name = params[:internal_name] + @loop = params[:loop] @catalog = load_catalog @state = EngineState.new(:loop => loop, :name => name, :internal_name => internal_name, :catalog => @catalog, :internal_connection_lifetime => - options[:internal_connection_lifetime]) + params[:internal_connection_lifetime]) @cluster = Cluster.new(:loop => loop, :catalog => @catalog, :internal_connection_lifetime => - options[:internal_connection_lifetime]) + params[:internal_connection_lifetime]) @dispatcher = create_dispatcher @cluster.on_change = lambda do -------------- next part -------------- HTML����������������������������...Download