[Groonga-commit] droonga/droonga-engine at 9223414 [master] Use named parameters instead of confusable list of arguments

Back to archive index

YUKI Hiroshi null+****@clear*****
Thu Apr 30 11:36:51 JST 2015


YUKI Hiroshi	2015-04-30 11:36:51 +0900 (Thu, 30 Apr 2015)

  New Revision: 9223414d94c4883b2f986155834123071de930a6
  https://github.com/droonga/droonga-engine/commit/9223414d94c4883b2f986155834123071de930a6

  Message:
    Use named parameters instead of confusable list of arguments

  Modified files:
    lib/droonga/cluster.rb
    lib/droonga/engine_node.rb

  Modified: lib/droonga/cluster.rb (+3 -3)
===================================================================
--- lib/droonga/cluster.rb    2015-04-30 11:34:48 +0900 (e81f8da)
+++ lib/droonga/cluster.rb    2015-04-30 11:36:51 +0900 (1ae1297)
@@ -222,9 +222,9 @@ module Droonga
     def create_engine_nodes
       all_node_names.collect do |name|
         node_state = @state[name] || {}
-        EngineNode.new(@loop,
-                       name,
-                       node_state,
+        EngineNode.new(:loop  => @loop,
+                       :name  => name,
+                       :state => node_state,
                        :auto_close_timeout =>
                          @params[:internal_connection_lifetime])
       end

  Modified: lib/droonga/engine_node.rb (+5 -5)
===================================================================
--- lib/droonga/engine_node.rb    2015-04-30 11:34:48 +0900 (266dcf0)
+++ lib/droonga/engine_node.rb    2015-04-30 11:36:51 +0900 (cc9e02e)
@@ -30,10 +30,10 @@ module Droonga
 
     attr_reader :name
 
-    def initialize(loop, name, state, options={})
-      @loop = loop
-      @name  = name
-      @state = state
+    def initialize(params={})
+      @loop  = params[:loop]
+      @name  = params[:name]
+      @state = params[:state]
       logger.trace("initialize: start")
 
       @buffer = ForwardBuffer.new(name)
@@ -47,7 +47,7 @@ module Droonga
 
       @sender = nil
       @auto_close_timer = nil
-      @auto_close_timeout = options[:auto_close_timeout] ||
+      @auto_close_timeout = params[:auto_close_timeout] ||
                               DEFAULT_AUTO_CLOSE_TIMEOUT_SECONDS
 
       logger.trace("initialize: done")
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Back to archive index