[Groonga-commit] groonga/grngo at a80a740 [master] Use grn_obj_is_table().

Back to archive index

susumu.yata null+****@clear*****
Fri Jul 10 15:28:28 JST 2015


susumu.yata	2015-07-10 15:28:28 +0900 (Fri, 10 Jul 2015)

  New Revision: a80a740df99c2f6431228171c0953883b158a234
  https://github.com/groonga/grngo/commit/a80a740df99c2f6431228171c0953883b158a234

  Message:
    Use grn_obj_is_table().

  Modified files:
    grngo.c

  Modified: grngo.c (+7 -24)
===================================================================
--- grngo.c    2015-07-10 15:27:46 +0900 (d1d65a9)
+++ grngo.c    2015-07-10 15:28:28 +0900 (ae28d8b)
@@ -16,37 +16,20 @@ grn_rc grngo_find_table(grn_ctx *ctx, const char *name, size_t name_len,
     }
     return GRN_UNKNOWN_ERROR;
   }
-  switch (obj->header.type) {
-    case GRN_TABLE_HASH_KEY:
-    case GRN_TABLE_PAT_KEY:
-    case GRN_TABLE_DAT_KEY:
-    case GRN_TABLE_NO_KEY: {
-      *table = obj;
-      return GRN_SUCCESS;
-    }
-    default: {
-      // The object is not a table.
-      grn_obj_unlink(ctx, obj);
-      return GRN_INVALID_FORMAT;
-    }
+  if (!grn_obj_is_table(ctx, obj)) {
+    grn_obj_unlink(ctx, obj);
+    return GRN_INVALID_FORMAT;
   }
+  *table = obj;
+  return GRN_SUCCESS;
 }
 
 grn_rc grngo_table_get_name(grn_ctx *ctx, grn_obj *table, char **name) {
   if (!ctx || !table || !name) {
     return GRN_INVALID_ARGUMENT;
   }
-  switch (table->header.type) {
-    case GRN_TABLE_HASH_KEY:
-    case GRN_TABLE_PAT_KEY:
-    case GRN_TABLE_DAT_KEY:
-    case GRN_TABLE_NO_KEY: {
-      break;
-    }
-    default: {
-      // The object is not a table.
-      return GRN_INVALID_FORMAT;
-    }
+  if (!grn_obj_is_table(ctx, table)) {
+    return GRN_INVALID_FORMAT;
   }
   char buf[GRN_TABLE_MAX_KEY_SIZE];
   int len = grn_obj_name(ctx, table, buf, GRN_TABLE_MAX_KEY_SIZE);
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Back to archive index