[Groonga-commit] groonga/groonga at 2ccc61b [master] logical_select: just parse --sortby

Back to archive index

Kouhei Sutou null+****@clear*****
Mon Jun 29 23:55:04 JST 2015


Kouhei Sutou	2015-06-29 23:55:04 +0900 (Mon, 29 Jun 2015)

  New Revision: 2ccc61bbd4d4645e032c49e836ea58c6083f7bfa
  https://github.com/groonga/groonga/commit/2ccc61bbd4d4645e032c49e836ea58c6083f7bfa

  Message:
    logical_select: just parse --sortby
    
    --sortby is *not* supported yet.

  Modified files:
    plugins/sharding/logical_select.rb

  Modified: plugins/sharding/logical_select.rb (+17 -14)
===================================================================
--- plugins/sharding/logical_select.rb    2015-06-29 22:59:29 +0900 (d1e37c9)
+++ plugins/sharding/logical_select.rb    2015-06-29 23:55:04 +0900 (7f51f68)
@@ -10,6 +10,7 @@ module Groonga
                  "max",
                  "max_border",
                  "filter",
+                 "sortby",
                  "output_columns",
                  "offset",
                  "limit",
@@ -98,11 +99,23 @@ module Groonga
         end
       end
 
+      module KeysParsable
+        private
+        def parse_keys(raw_keys)
+          return [] if raw_keys.nil?
+
+          raw_keys.strip.split(/ *, */)
+        end
+      end
+
       class ExecuteContext
+        include KeysParsable
+
         attr_reader :enumerator
         attr_reader :filter
         attr_reader :offset
         attr_reader :limit
+        attr_reader :sort_keys
         attr_reader :result_sets
         attr_reader :drilldown
         def initialize(input)
@@ -111,6 +124,7 @@ module Groonga
           @filter = @input[:filter]
           @offset = (@input[:offset] || 0).to_i
           @limit = (@input[:limit] || 10).to_i
+          @sort_keys = parse_keys(input[:drilldown_sortby])
 
           @result_sets = []
 
@@ -127,6 +141,8 @@ module Groonga
       end
 
       class DrilldownExecuteContext
+        include KeysParsable
+
         attr_reader :keys
         attr_reader :offset
         attr_reader :limit
@@ -139,7 +155,7 @@ module Groonga
           @keys = parse_keys(input[:drilldown])
           @offset = (input[:drilldown_offset] || 0).to_i
           @limit = (input[:drilldown_limit] || 10).to_i
-          @sort_keys = parse_sort_keys(input[:drilldown_sortby])
+          @sort_keys = parse_keys(input[:drilldown_sortby])
 
           if @sort_keys.empty?
             @output_offset = @offset
@@ -159,19 +175,6 @@ module Groonga
             result_set.close
           end
         end
-
-        private
-        def parse_keys(raw_keys)
-          return [] if raw_keys.nil?
-
-          raw_keys.strip.split(/ *, */)
-        end
-
-        def parse_sort_keys(raw_sort_keys)
-          return [] if raw_sort_keys.nil?
-
-          raw_sort_keys.strip.split(/ *, */)
-        end
       end
 
       class Executor
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Back to archive index