Kouhei Sutou
null+****@clear*****
Fri Mar 20 11:37:15 JST 2015
Kouhei Sutou 2015-03-20 11:37:15 +0900 (Fri, 20 Mar 2015) New Revision: c1ff1e55491241933e3c25f90bdd434d370edaf0 https://github.com/droonga/droonga-engine/commit/c1ff1e55491241933e3c25f90bdd434d370edaf0 Message: Use positive word for method name Negative word may confuse with us. Modified files: lib/droonga/serf/agent.rb Modified: lib/droonga/serf/agent.rb (+5 -5) =================================================================== --- lib/droonga/serf/agent.rb 2015-03-20 11:35:13 +0900 (4124567) +++ lib/droonga/serf/agent.rb 2015-03-20 11:37:15 +0900 (3b9bffe) @@ -138,7 +138,7 @@ module Droonga hour, minute, second = $4, $5, $6 level = $7 content = $POSTMATCH - return if suppressed_log_message?(content) + return unless needed_log_message?(content) level = normalize_level(level) logger.send(level, content) else @@ -150,16 +150,16 @@ module Droonga end end - def suppressed_log_message?(content) + def needed_log_message?(content) case content when /\Amemberlist: Failed to receive remote state: EOF\z/ # See also: https://github.com/hashicorp/consul/issues/598#issuecomment-71576948 - true + false when /\Aagent: Script .*droonga-engine-serf-event-handler.* slow, execution exceeding/ # Droonga's serf event handler can be slow for absorbing or some operations. - true - else false + else + true end end -------------- next part -------------- HTML����������������������������... Download