[Groonga-commit] ranguba/rroonga at 205a22c [master] Fix wrong flags value in FixSizeColumn#inspect

Back to archive index

Kouhei Sutou null+****@clear*****
Fri Aug 12 17:28:45 JST 2016


Kouhei Sutou	2016-08-12 17:28:45 +0900 (Fri, 12 Aug 2016)

  New Revision: 205a22c90ff0564c7ff8c12c96b40262891dd9e9
  https://github.com/ranguba/rroonga/commit/205a22c90ff0564c7ff8c12c96b40262891dd9e9

  Message:
    Fix wrong flags value in FixSizeColumn#inspect

  Modified files:
    ext/groonga/rb-grn-object.c
    test/test-fix-size-column.rb

  Modified: ext/groonga/rb-grn-object.c (+19 -19)
===================================================================
--- ext/groonga/rb-grn-object.c    2016-08-12 16:43:06 +0900 (8247996)
+++ ext/groonga/rb-grn-object.c    2016-08-12 17:28:45 +0900 (e367da0)
@@ -852,29 +852,29 @@ rb_grn_object_inspect_content_flags_with_label (VALUE inspected,
     switch (object->header.type) {
       case GRN_COLUMN_FIX_SIZE:
       case GRN_COLUMN_VAR_SIZE:
-      case GRN_TYPE:
         if (flags & GRN_OBJ_KEY_VAR_SIZE) {
             rb_ary_push(inspected_flags, rb_str_new_cstr("KEY_VAR_SIZE"));
-        } else {
-            switch (flags & GRN_OBJ_KEY_MASK) {
-              case GRN_OBJ_KEY_UINT:
-                rb_ary_push(inspected_flags, rb_str_new_cstr("KEY_UINT"));
-                break;
-              case GRN_OBJ_KEY_INT:
-                rb_ary_push(inspected_flags, rb_str_new_cstr("KEY_INT"));
-                break;
-              case GRN_OBJ_KEY_FLOAT:
-                rb_ary_push(inspected_flags, rb_str_new_cstr("KEY_FLOAT"));
-                break;
-              case GRN_OBJ_KEY_GEO_POINT:
-                rb_ary_push(inspected_flags, rb_str_new_cstr("KEY_GEO_POINT"));
-                break;
-              default:
-                break;
-            }
         }
         break;
-      default:
+      case GRN_TYPE:
+        switch (flags & GRN_OBJ_KEY_MASK) {
+        case GRN_OBJ_KEY_UINT:
+            rb_ary_push(inspected_flags, rb_str_new_cstr("KEY_UINT"));
+            break;
+        case GRN_OBJ_KEY_INT:
+            rb_ary_push(inspected_flags, rb_str_new_cstr("KEY_INT"));
+            break;
+        case GRN_OBJ_KEY_FLOAT:
+            rb_ary_push(inspected_flags, rb_str_new_cstr("KEY_FLOAT"));
+            break;
+        case GRN_OBJ_KEY_GEO_POINT:
+            rb_ary_push(inspected_flags, rb_str_new_cstr("KEY_GEO_POINT"));
+            break;
+        default:
+            break;
+        }
+        break;
+    default:
         break;
     }
 

  Modified: test/test-fix-size-column.rb (+1 -1)
===================================================================
--- test/test-fix-size-column.rb    2016-08-12 16:43:06 +0900 (d2a8f4a)
+++ test/test-fix-size-column.rb    2016-08-12 17:28:45 +0900 (976f07b)
@@ -139,7 +139,7 @@ class FixSizeColumnTest < Test::Unit::TestCase
                    "path: <#{@n_viewed_column_path}>, " +
                    "domain: <Bookmarks>, " +
                    "range: <Int32>, " +
-                   "flags: <KEY_INT>" +
+                   "flags: <>" +
                    ">",
                    @n_viewed.inspect)
     end
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Back to archive index