Kouhei Sutou
null+****@clear*****
Mon Dec 12 13:43:38 JST 2016
Kouhei Sutou 2016-12-12 13:43:38 +0900 (Mon, 12 Dec 2016) New Revision: 66db32ad1f3752c25b34fac7fc6041be7482e8ec https://github.com/ranguba/groonga-client/commit/66db32ad1f3752c25b34fac7fc6041be7482e8ec Message: extend -> extensions We use noun for target instead of verb like other methods such as filter and query. Modified files: lib/groonga/client/request/base.rb test/request/test-base.rb Modified: lib/groonga/client/request/base.rb (+2 -4) =================================================================== --- lib/groonga/client/request/base.rb 2016-12-12 12:22:38 +0900 (843d9e9) +++ lib/groonga/client/request/base.rb 2016-12-12 13:43:38 +0900 (56bdff7) @@ -21,9 +21,7 @@ module Groonga def initialize(parameters=nil, extensions=[]) @parameters = parameters @extensions = extensions - unles****@exten*****? - Object.instance_method(:extend).bind(self).call(*@extensions) - end + extend(*@extensions) unles****@exten*****? end def response @@ -43,7 +41,7 @@ module Groonga end end - def extend(*modules, &block) + def extensions(*modules, &block) modules << Module.new(&block) if block if modules.empty? self Modified: test/request/test-base.rb (+3 -3) =================================================================== --- test/request/test-base.rb 2016-12-12 12:22:38 +0900 (e61aeb5) +++ test/request/test-base.rb 2016-12-12 13:43:38 +0900 (973de0a) @@ -15,7 +15,7 @@ # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA class TestRequestBase < Test::Unit::TestCase - sub_test_case "#extend" do + sub_test_case "#extensions" do setup do @request = Groonga::Client::Request::Base.new("status") end @@ -28,7 +28,7 @@ class TestRequestBase < Test::Unit::TestCase def new_method end end - extended_request =****@reque*****(extension) + extended_request =****@reque*****(extension) assert do extended_request.respond_to?(:new_method) end @@ -38,7 +38,7 @@ class TestRequestBase < Test::Unit::TestCase assert do not****@reque*****_to?(:new_method) end - extended_request =****@reque***** do + extended_request =****@reque***** do def new_method end end -------------- next part -------------- HTML����������������������������...Download