Kouhei Sutou
null+****@clear*****
Thu Apr 13 13:25:54 JST 2017
Kouhei Sutou 2017-04-13 13:25:54 +0900 (Thu, 13 Apr 2017) New Revision: 17c2231f2d594dd9a88a840e27580ba1e33adcef https://github.com/ranguba/groonga-client/commit/17c2231f2d594dd9a88a840e27580ba1e33adcef Message: Require at least one value Modified files: lib/groonga/client/request/select.rb test/request/test-select.rb Modified: lib/groonga/client/request/select.rb (+8 -4) =================================================================== --- lib/groonga/client/request/select.rb 2017-04-13 13:21:19 +0900 (aa8edd4) +++ lib/groonga/client/request/select.rb 2017-04-13 13:25:54 +0900 (f6f561b) @@ -187,17 +187,21 @@ module Groonga # # @param [String, Symbol] column_name The target column name. # - # @param [Object] values The column values that cover target + # @param [Object] value A column value that cover target # column values. # + # @param [Object] values The rest column values that cover + # target column values. + # # Adds a `in_values` condition then return a new `select` # request object. # # @return [Groonga::Client::Request::Select] # The new request with the given condition. - def in_values(column_name, *values) - add_parameter(FilterMerger, - FilterInValuesParameters.new(column_name, *values)) + def in_values(column_name, value, *values) + parameters = + FilterInValuesParameters.new(column_name, value, *values) + add_parameter(FilterMerger, parameters) end private Modified: test/request/test-select.rb (+6 -0) =================================================================== --- test/request/test-select.rb 2017-04-13 13:21:19 +0900 (1a1a87c) +++ test/request/test-select.rb 2017-04-13 13:25:54 +0900 (1a9358e) @@ -112,6 +112,12 @@ class TestRequestSelect < Test::Unit::TestCase }, in_values("tags", "groonga", "have \"double\" quote")) end + + test("no values") do + assert_raise(ArgumentError) do + in_values("tags") + end + end end end -------------- next part -------------- HTML����������������������������...Download