Kouhei Sutou
null+****@clear*****
Wed Apr 26 15:12:00 JST 2017
Kouhei Sutou 2017-04-26 15:12:00 +0900 (Wed, 26 Apr 2017) New Revision: fa1d2d1e5d181af487f92882db9de6c9324b6c50 https://github.com/ranguba/groonga-client/commit/fa1d2d1e5d181af487f92882db9de6c9324b6c50 Message: Stop to use needless variable length arguments Modified files: lib/groonga/client/request/select.rb Modified: lib/groonga/client/request/select.rb (+14 -8) =================================================================== --- lib/groonga/client/request/select.rb 2017-04-26 15:09:30 +0900 (978282d) +++ lib/groonga/client/request/select.rb 2017-04-26 15:12:00 +0900 (ed46d84) @@ -509,19 +509,25 @@ module Groonga class FilterBetweenParameter include ScriptSyntaxValueEscapable - def initialize(column_name, *values) + def initialize(column_name, + min, min_border, + max, max_border) @column_name = column_name - @values = values + @min = min + @min_border = min_border + @max = max + @max_border = max_border end def to_parameters - return {} if****@value*****? - - escaped_values =****@value***** do |value| - escape_script_syntax_value(value) - end + filter = "between(#{@column_name}" + filter << ", #{escape_script_syntax_value(@min)}" + filter << ", #{escape_script_syntax_value(@min_border)}" + filter << ", #{escape_script_syntax_value(@max)}" + filter << ", #{escape_script_syntax_value(@max_border)}" + filter << ")" { - filter: "between(#{@column_name}, #{escaped_values.join(", ")})", + filter: filter, } end end -------------- next part -------------- HTML����������������������������...Download