[Groonga-commit] Still Failing: ranguba/groonga-client#396 (master - 8ff9649)

Back to archive index

Travis CI build****@travi*****
Thu Apr 27 09:34:25 JST 2017


Build Update for ranguba/groonga-client
-------------------------------------

Build: #396
Status: Still Failing

Duration: 1 minute and 10 seconds
Commit: 8ff9649 (master)
Author: Kouhei Sutou
Message: select: change Symbol handling in script syntax

This is a backward incompatible change. But the use case affected by
this change will make Ruby scripts difficult to maintain. I hope that
existing users didn't match the use case. The use case is using Symbol
as string value in script syntax like the following:

    filter("title", :value) # => --filter "title == \"value\""

Before this change, all Symbol are treated as string value in script
syntax. We can't specify column (object in general) in script syntax
with the specification.

With this change, Symbol is treated as identifier. It means that Symbol
is treated as column (object in general) in script syntax like the
following:

    filter("title", :normalized_title) # => --filter "title == normalized_title"

For backward compatibility, invalid identifier in script syntax is
fallbacked to string value in script syntax like the following:

    filter("title", :"Hello World") # => --filter "title == \"Hello World\""

I think that an exception should be raised for the case but I choose the
above specification...

View the changeset: https://github.com/ranguba/groonga-client/compare/ab55abb6aae5...8ff9649b1491

View the full build log and details: https://travis-ci.org/ranguba/groonga-client/builds/226227411

--

You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

-------------- next part --------------
An HTML attachment was scrubbed...
Download 



More information about the Groonga-commit mailing list
Back to archive index