[Groonga-commit] groonga/grnci at 3f0678f [master] Add tests for column_create.

Back to archive index

Susumu Yata null+****@clear*****
Fri Jul 7 18:38:02 JST 2017


Susumu Yata	2017-07-07 18:38:02 +0900 (Fri, 07 Jul 2017)

  New Revision: 3f0678fe7e72220f3ce40453888dba023c29da2f
  https://github.com/groonga/grnci/commit/3f0678fe7e72220f3ce40453888dba023c29da2f

  Message:
    Add tests for column_create.
    
    GitHub: #39

  Modified files:
    v2/libgrn/db_test.go

  Modified: v2/libgrn/db_test.go (+38 -17)
===================================================================
--- v2/libgrn/db_test.go    2017-07-07 14:46:55 +0900 (b6ecffd)
+++ v2/libgrn/db_test.go    2017-07-07 18:38:02 +0900 (21fc135)
@@ -87,24 +87,45 @@ func TestDBColumnListInvalidTable(t *testing.T) {
 // 	}
 // }
 
-// func TestDBColumnCreate(t *testing.T) {
-// 	client, err := NewHTTPClient("", nil)
-// 	if err != nil {
-// 		t.Skipf("NewHTTPClient failed: %v", err)
-// 	}
-// 	db := NewDB(client)
-// 	defer db.Close()
+func TestDBColumnCreate(t *testing.T) {
+	db, dir := makeDB(t)
+	defer removeDB(db, dir)
 
-// 	result, resp, err := db.ColumnCreate("Tbl.col", "ShortText", nil)
-// 	if err != nil {
-// 		t.Fatalf("db.ColumnCreate failed: %v", err)
-// 	}
-// 	log.Printf("result = %#v", result)
-// 	log.Printf("resp = %#v", resp)
-// 	if err := resp.Err(); err != nil {
-// 		log.Printf("error = %#v", err)
-// 	}
-// }
+	dump := `table_create Tbl TABLE_NO_KEY`
+	if _, err := db.Restore(strings.NewReader(dump), nil, true); err != nil {
+		t.Fatalf("db.Restore failed: %v", err)
+	}
+	_, resp, err := db.ColumnCreate("Tbl.col", "Text", nil)
+	if err == nil {
+		err = resp.Err()
+	}
+	if err != nil {
+		t.Fatalf("db.ColumnCreate failed: %v", err)
+	}
+	result, resp, err := db.ObjectExist("Tbl.col")
+	if err == nil {
+		err = resp.Err()
+	}
+	if err != nil {
+		t.Fatalf("db.ObjectExist failed: %v", err)
+	}
+	if !result {
+		t.Fatalf("Column not found")
+	}
+}
+
+func TestDBColumnCreateInvalidTable(t *testing.T) {
+	db, dir := makeDB(t)
+	defer removeDB(db, dir)
+
+	_, resp, err := db.ColumnCreate("no_such_table.col", "Text", nil)
+	if err != nil {
+		t.Fatalf("db.ColumnCreate failed: %v", err)
+	}
+	if resp.Err() == nil {
+		t.Fatalf("db.ColumnCreate wrongly succeeded")
+	}
+}
 
 func TestDBColumnRemove(t *testing.T) {
 	db, dir := makeDB(t)
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Back to archive index