Kouhei Sutou
null+****@clear*****
Wed Mar 1 14:32:58 JST 2017
Kouhei Sutou 2017-03-01 14:32:58 +0900 (Wed, 01 Mar 2017) New Revision: 918d06fd1d4b52280b53d8e862320510e5d7863e https://github.com/ranguba/groonga-client/commit/918d06fd1d4b52280b53d8e862320510e5d7863e Message: Make command name customizable per instance Modified files: lib/groonga/client/request.rb lib/groonga/client/request/select.rb Renamed files: lib/groonga/client/request/generic.rb (from lib/groonga/client/request/base.rb) test/request/test-generic.rb (from test/request/test-base.rb) Modified: lib/groonga/client/request.rb (+1 -1) =================================================================== --- lib/groonga/client/request.rb 2017-02-07 14:42:37 +0900 (a00ceea) +++ lib/groonga/client/request.rb 2017-03-01 14:32:58 +0900 (2676bcb) @@ -16,7 +16,7 @@ require "groonga/client/script-syntax" -require "groonga/client/request/base" require "groonga/client/request/error" +require "groonga/client/request/generic" require "groonga/client/request/select" Renamed: lib/groonga/client/request/generic.rb (+6 -2) 96% =================================================================== --- lib/groonga/client/request/base.rb 2017-02-07 14:42:37 +0900 (5acc04d) +++ lib/groonga/client/request/generic.rb 2017-03-01 14:32:58 +0900 (b4759b3) @@ -17,7 +17,7 @@ module Groonga class Client module Request - class Base + class Generic def initialize(parameters=nil, extensions=[]) @parameters = parameters @extensions = extensions @@ -60,9 +60,13 @@ module Groonga self.class.new(parameters, extensions) end + def command_name + self.class.command_name + end + def create_response open_client do |client| - response = client.execute(self.class.command_name, to_parameters) + response = client.execute(command_name, to_parameters) raise ErrorResponse.new(response) unless response.success? response end Modified: lib/groonga/client/request/select.rb (+1 -1) =================================================================== --- lib/groonga/client/request/select.rb 2017-02-07 14:42:37 +0900 (5783529) +++ lib/groonga/client/request/select.rb 2017-03-01 14:32:58 +0900 (d94a963) @@ -17,7 +17,7 @@ module Groonga class Client module Request - class Select < Base + class Select < Generic include Enumerable class << self Renamed: test/request/test-generic.rb (+3 -3) 88% =================================================================== --- test/request/test-base.rb 2017-02-07 14:42:37 +0900 (973de0a) +++ test/request/test-generic.rb 2017-03-01 14:32:58 +0900 (29c2945) @@ -1,4 +1,4 @@ -# Copyright (C) 2016 Kouhei Sutou <kou �� clear-code.com> +# Copyright (C) 2016-2017 Kouhei Sutou <kou �� clear-code.com> # # This library is free software; you can redistribute it and/or # modify it under the terms of the GNU Lesser General Public @@ -14,10 +14,10 @@ # License along with this library; if not, write to the Free Software # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA -class TestRequestBase < Test::Unit::TestCase +class TestRequestGeneric < Test::Unit::TestCase sub_test_case "#extensions" do setup do - @request = Groonga::Client::Request::Base.new("status") + @request = Groonga::Client::Request::Generic.new("status") end test "Module" do -------------- next part -------------- HTML����������������������������...Download