[Groonga-commit] groonga/fluent-plugin-groonga at c1680f5 [master] out: use more rubyish method

Back to archive index

Kenji Okimoto okimo****@clear*****
Mon May 15 17:07:17 JST 2017


alias で formatted_to_msgpack_binary
も残しておいた方が後方互換性的によさそうです。

On 2017年05月15日 12:08, Kentaro Hayashi wrote:
> Author
>     Kentaro Hayashi <hayashi �� clear-code.com>
> Date
>     2017-05-15 12:08:58 +0900 (Mon, 15 May 2017)
> New Revision
>     c1680f5e9a9122d4d4d23d1733d3c75f248e47a1
>     <https://github.com/groonga/fluent-plugin-groonga/commit/c1680f5e9a9122d4d4d23d1733d3c75f248e47a1>
> Merge
> 
>       * Merged 78fd596
>         <https://github.com/groonga/fluent-plugin-groonga/commit/78fd596>:
>         Merge pull request #21
>         <https://github.com/groonga/fluent-plugin-groonga/issues/21>
>         from kenhys/use-formatted-to-msgpack-binary-q
> 
> Message
> 
>     out: use more rubyish method
> 
>     before:
> 
>       formatted_to_msgpack_binary
> 
>     after:
> 
>       formatted_to_msgpack_binary?
> 
>     See http://www.fluentd.org/blog/fluentd-v0.14.15-has-been-released
>     blog entry why this method is introduced.
> 
> Modified files
> 
>       * lib/fluent/plugin/out_groonga.rb
>         <https://github.com/groonga/fluent-plugin-groonga/commit/c1680f5e9a9122d4d4d23d1733d3c75f248e47a1#diff-e11d0ce8ffa370c51a4b9237ffcb8a50>
> 
> Modified: lib/fluent/plugin/out_groonga.rb (+1 -1)
> ===================================================================
> 
> ...
> <https://github.com/groonga/fluent-plugin-groonga/commit/c1680f5e9a9122d4d4d23d1733d3c75f248e47a1#diff-e11d0ce8ffa370c51a4b9237ffcb8a50L112>
> 113
> <https://github.com/groonga/fluent-plugin-groonga/commit/c1680f5e9a9122d4d4d23d1733d3c75f248e47a1#diff-e11d0ce8ffa370c51a4b9237ffcb8a50L113>
> 114
> <https://github.com/groonga/fluent-plugin-groonga/commit/c1680f5e9a9122d4d4d23d1733d3c75f248e47a1#diff-e11d0ce8ffa370c51a4b9237ffcb8a50L114>
> 115
> <https://github.com/groonga/fluent-plugin-groonga/commit/c1680f5e9a9122d4d4d23d1733d3c75f248e47a1#diff-e11d0ce8ffa370c51a4b9237ffcb8a50L115>
> 116
> <https://github.com/groonga/fluent-plugin-groonga/commit/c1680f5e9a9122d4d4d23d1733d3c75f248e47a1#diff-e11d0ce8ffa370c51a4b9237ffcb8a50L116>
>  
> 117
> <https://github.com/groonga/fluent-plugin-groonga/commit/c1680f5e9a9122d4d4d23d1733d3c75f248e47a1#diff-e11d0ce8ffa370c51a4b9237ffcb8a50L117>
> 118
> <https://github.com/groonga/fluent-plugin-groonga/commit/c1680f5e9a9122d4d4d23d1733d3c75f248e47a1#diff-e11d0ce8ffa370c51a4b9237ffcb8a50L118>
> 119
> <https://github.com/groonga/fluent-plugin-groonga/commit/c1680f5e9a9122d4d4d23d1733d3c75f248e47a1#diff-e11d0ce8ffa370c51a4b9237ffcb8a50L119>
> 
> 	
> 
> ...
> <https://github.com/groonga/fluent-plugin-groonga/commit/c1680f5e9a9122d4d4d23d1733d3c75f248e47a1#diff-e11d0ce8ffa370c51a4b9237ffcb8a50R112>
> 113
> <https://github.com/groonga/fluent-plugin-groonga/commit/c1680f5e9a9122d4d4d23d1733d3c75f248e47a1#diff-e11d0ce8ffa370c51a4b9237ffcb8a50R113>
> 114
> <https://github.com/groonga/fluent-plugin-groonga/commit/c1680f5e9a9122d4d4d23d1733d3c75f248e47a1#diff-e11d0ce8ffa370c51a4b9237ffcb8a50R114>
> 115
> <https://github.com/groonga/fluent-plugin-groonga/commit/c1680f5e9a9122d4d4d23d1733d3c75f248e47a1#diff-e11d0ce8ffa370c51a4b9237ffcb8a50R115>
>  
> 116
> <https://github.com/groonga/fluent-plugin-groonga/commit/c1680f5e9a9122d4d4d23d1733d3c75f248e47a1#diff-e11d0ce8ffa370c51a4b9237ffcb8a50R116>
> 117
> <https://github.com/groonga/fluent-plugin-groonga/commit/c1680f5e9a9122d4d4d23d1733d3c75f248e47a1#diff-e11d0ce8ffa370c51a4b9237ffcb8a50R117>
> 118
> <https://github.com/groonga/fluent-plugin-groonga/commit/c1680f5e9a9122d4d4d23d1733d3c75f248e47a1#diff-e11d0ce8ffa370c51a4b9237ffcb8a50R118>
> 119
> <https://github.com/groonga/fluent-plugin-groonga/commit/c1680f5e9a9122d4d4d23d1733d3c75f248e47a1#diff-e11d0ce8ffa370c51a4b9237ffcb8a50R119>
> 
> 	
> 
> @@ -113,7 +113,7 @@ module Fluent
> [tag, time, record].to_msgpack
> end
> 
> - def formatted_to_msgpack_binary
> + def formatted_to_msgpack_binary?
> true
> end
> 
> 
> 
> _______________________________________________
> Groonga-commit mailing list
> Groonga-commit �� lists.osdn.me
> http://lists.osdn.me/mailman/listinfo/groonga-commit
> 

-- 
Kenji Okimoto <okimoto �� clear-code.com>




More information about the Groonga-commit mailing list
Back to archive index