[Groonga-commit] groonga/groonga at b92ae52 [master] sharding: remove needless #close

Back to archive index

Kouhei Sutou null+****@clear*****
Tue Nov 7 14:33:06 JST 2017


Kouhei Sutou	2017-11-07 14:33:06 +0900 (Tue, 07 Nov 2017)

  New Revision: b92ae524c9f35a49380043a618c0028f9e0498ed
  https://github.com/groonga/groonga/commit/b92ae524c9f35a49380043a618c0028f9e0498ed

  Message:
    sharding: remove needless #close

  Modified files:
    plugins/sharding/dynamic_columns.rb
    plugins/sharding/logical_range_filter.rb
    plugins/sharding/logical_select.rb

  Modified: plugins/sharding/dynamic_columns.rb (+0 -9)
===================================================================
--- plugins/sharding/dynamic_columns.rb    2017-11-07 10:35:00 +0900 (a01651931)
+++ plugins/sharding/dynamic_columns.rb    2017-11-07 14:33:06 +0900 (6da0a5e47)
@@ -60,12 +60,6 @@ module Groonga
           @output_contexts.empty?
       end
 
-      def close
-        each do |context|
-          context.close
-        end
-      end
-
       def cache_key
         key = ""
         [
@@ -107,9 +101,6 @@ module Groonga
         @window_group_keys = parse_keys(arguments["window.group_keys"])
       end
 
-      def close
-      end
-
       def apply(table, condition=nil)
         column = table.create_column(@label, @flags, @type)
         return if table.empty?

  Modified: plugins/sharding/logical_range_filter.rb (+0 -2)
===================================================================
--- plugins/sharding/logical_range_filter.rb    2017-11-07 10:35:00 +0900 (f4defa05c)
+++ plugins/sharding/logical_range_filter.rb    2017-11-07 14:33:06 +0900 (cbb1545b7)
@@ -119,8 +119,6 @@ module Groonga
             result_set.close if result_set.temporary?
           end
 
-          @dynamic_columns.close
-
           @temporary_tables.each do |table|
             table.close
           end

  Modified: plugins/sharding/logical_select.rb (+0 -4)
===================================================================
--- plugins/sharding/logical_select.rb    2017-11-07 10:35:00 +0900 (1ffa380b8)
+++ plugins/sharding/logical_select.rb    2017-11-07 14:33:06 +0900 (106242d47)
@@ -297,8 +297,6 @@ module Groonga
           @plain_drilldown.close
           @labeled_drilldowns.close
 
-          @dynamic_columns.close
-
           @temporary_tables.each do |table|
             table.close
           end
@@ -483,8 +481,6 @@ module Groonga
           @result_set.close if @result_set
           @unsorted_result_set.close if @unsorted_result_set
 
-          @dynamic_columns.close
-
           @temporary_tables.each do |table|
             table.close
           end
-------------- next part --------------
HTML����������������������������...
URL: https://lists.osdn.me/mailman/archives/groonga-commit/attachments/20171107/ceeace09/attachment-0001.htm 



More information about the Groonga-commit mailing list
Back to archive index