[Groonga-commit] groonga/groonga at e3db12d [master] Remove -Wextra flag

Back to archive index

Kouhei Sutou null+****@clear*****
Sun Sep 3 13:30:46 JST 2017


Kouhei Sutou	2017-09-03 13:30:46 +0900 (Sun, 03 Sep 2017)

  New Revision: e3db12d9134556f6406d52c6fdc47a216fe9fece
  https://github.com/groonga/groonga/commit/e3db12d9134556f6406d52c6fdc47a216fe9fece

  Message:
    Remove -Wextra flag
    
    We can't maintain it.

  Modified files:
    CMakeLists.txt
    configure.ac

  Modified: CMakeLists.txt (+0 -5)
===================================================================
--- CMakeLists.txt    2017-08-30 17:01:17 +0900 (eb33a1477)
+++ CMakeLists.txt    2017-09-03 13:30:46 +0900 (7f3d2ad26)
@@ -174,12 +174,8 @@ endmacro()
 
 if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_COMPILER_IS_CLANGCXX)
   check_build_flag("-Wall")
-  check_build_flag("-Wextra")
   check_build_flag("-Wno-unused-but-set-variable")
-  check_build_flag("-Wno-unused-parameter")
-  check_build_flag("-Wno-sign-compare")
   check_cflag("-Wno-pointer-sign")
-  check_build_flag("-Wno-missing-field-initializers")
   check_build_flag("-Wformat")
   check_build_flag("-Wstrict-aliasing=2")
   check_build_flag("-fno-strict-aliasing")
@@ -194,7 +190,6 @@ if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_COMPILER_IS_CLANGCXX)
   check_build_flag("-Wwrite-strings")
   check_cxxflag("-fexceptions")
   check_cxxflag("-fimplicit-templates")
-  check_build_flag("-Wno-clobbered")
 endif()
 
 if(NOT DEFINED CMAKE_C_COMPILE_OPTIONS_PIC)

  Modified: configure.ac (+0 -16)
===================================================================
--- configure.ac    2017-08-30 17:01:17 +0900 (7344d0d8f)
+++ configure.ac    2017-09-03 13:30:46 +0900 (414876c6a)
@@ -152,15 +152,11 @@ NO_FLOAT_EQUAL_CFLAGS=""
 NO_BAD_FUNCTION_CAST_CFLAGS=""
 if test "$GCC" = "yes"; then
   CHECK_BUILD_FLAG([-Wall])
-  CHECK_BUILD_FLAG([-Wextra])
   if test "x$check_cflag" = "xno"; then
     CHECK_BUILD_FLAG([-W])
   fi
   CHECK_BUILD_FLAG([-Wno-unused-but-set-variable]) # FIXME: enable it.
-  CHECK_BUILD_FLAG([-Wno-unused-parameter])
-  CHECK_BUILD_FLAG([-Wno-sign-compare])
   CHECK_CFLAG([-Wno-pointer-sign])
-  CHECK_BUILD_FLAG([-Wno-missing-field-initializers])
   CHECK_CFLAG([-Wno-declaration-after-statement])
 
   CHECK_BUILD_FLAG([-Wformat])
@@ -192,18 +188,6 @@ if test "$GCC" = "yes"; then
 
   CHECK_CXXFLAG([-fexceptions])
   CHECK_CXXFLAG([-fimplicit-templates])
-
-  CFLAGS_for_source="$CFLAGS"
-  CXXFLAGS_for_source="$CXXFLAGS"
-  CHECK_BUILD_FLAG([-Wno-clobbered])
-  if test "x$check_cflag" = "xyes"; then
-    TEST_CFLAGS="-Wno-clobbered"
-  fi
-  if test "x$check_cxxflag" = "xyes"; then
-    TEST_CXXFLAGS="-Wno-clobbered"
-  fi
-  CFLAGS="$CFLAGS_for_source"
-  CXXFLAGS="$CXXFLAGS_for_source"
 fi
 AC_SUBST(TEST_CFLAGS)
 AC_SUBST(TEST_CXXFLAGS)
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Back to archive index