[Groonga-commit] nroonga/nroonga at 454e047 [master] Fix to use nan helper method

Back to archive index

abetomo null+****@clear*****
Tue Sep 5 11:09:00 JST 2017


abetomo	2017-09-05 11:09:00 +0900 (Tue, 05 Sep 2017)

  New Revision: 454e047001ba1275c7dac66265d9e587fc81b4b7
  https://github.com/nroonga/nroonga/commit/454e047001ba1275c7dac66265d9e587fc81b4b7

  Merged aa61187: Merge pull request #13 from abetomo/use_nan_helper_method

  Message:
    Fix to use nan helper method
    
    - True
    - Null
    - Undefined

  Modified files:
    src/nroonga.cc

  Modified: src/nroonga.cc (+4 -4)
===================================================================
--- src/nroonga.cc    2017-09-05 10:40:29 +0900 (eafa12e)
+++ src/nroonga.cc    2017-09-05 11:09:00 +0900 (262eff9)
@@ -83,7 +83,7 @@ void Database::Close(const FunctionCallbackInfo<Value>& args) {
   }
 
   if (db->Cleanup()) {
-    args.GetReturnValue().Set(True(isolate));
+    args.GetReturnValue().Set(Nan::True());
     return;
   }
   Nan::ThrowTypeError("Failed to close the database");
@@ -123,9 +123,9 @@ void Database::CommandAfter(uv_work_t* req) {
   if (baton->error) {
     argv[0] = Exception::Error(String::NewFromUtf8(isolate,
                                                    baton->context.errbuf));
-    argv[1] = Null(isolate);
+    argv[1] = Nan::Null();
   } else {
-    argv[0] = Null(isolate);
+    argv[0] = Nan::Null();
     argv[1] = Buffer::New(isolate, baton->result, baton->result_length)
         .ToLocalChecked();
   }
@@ -172,7 +172,7 @@ void Database::CommandString(const FunctionCallbackInfo<Value>& args) {
       (uv_after_work_cb)CommandAfter
       );
 
-  args.GetReturnValue().Set(Undefined(isolate));
+  args.GetReturnValue().Set(Nan::Undefined());
 }
 
 void Database::CommandSyncString(const FunctionCallbackInfo<Value>& args) {
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Back to archive index