abetomo
null+****@clear*****
Wed Sep 6 17:25:05 JST 2017
abetomo 2017-09-06 17:25:05 +0900 (Wed, 06 Sep 2017) New Revision: 50a8d87b0eb8d0cd97e42b25e8001446ebbfeed7 https://github.com/nroonga/nroonga/commit/50a8d87b0eb8d0cd97e42b25e8001446ebbfeed7 Merged b409f9a: Merge pull request #15 from abetomo/remove_namespace_v8 Message: Remove `using namespace v8` in nroonga.h It is because it was not used in `nan` usage examples. https://github.com/nodejs/node-addon-examples/tree/6a51626da3438a59d31d43229cee3e6fd09ec8a5/6_object_wrap/nan Modified files: src/nroonga.h Modified: src/nroonga.h (+5 -8) =================================================================== --- src/nroonga.h 2017-09-06 17:23:03 +0900 (2799ce2) +++ src/nroonga.h 2017-09-06 17:25:05 +0900 (f5a7c18) @@ -2,13 +2,10 @@ #define NROONGA_GROONGA_H #include <nan.h> #include <uv.h> -#include <v8.h> #include <groonga.h> #include <string> -using namespace v8; - namespace nroonga { class Database : public Nan::ObjectWrap { @@ -21,7 +18,7 @@ class Database : public Nan::ObjectWrap { struct Baton { uv_work_t request; - Nan::Persistent<Function> callback; + Nan::Persistent<v8::Function> callback; int error; char *result; unsigned int result_length; @@ -32,10 +29,10 @@ class Database : public Nan::ObjectWrap { }; protected: - static void New(const Nan::FunctionCallbackInfo<Value>& info); - static void CommandString(const Nan::FunctionCallbackInfo<Value>& info); - static void CommandSyncString(const Nan::FunctionCallbackInfo<Value>& info); - static void Close(const Nan::FunctionCallbackInfo<Value>& info); + static void New(const Nan::FunctionCallbackInfo<v8::Value>& info); + static void CommandString(const Nan::FunctionCallbackInfo<v8::Value>& info); + static void CommandSyncString(const Nan::FunctionCallbackInfo<v8::Value>& info); + static void Close(const Nan::FunctionCallbackInfo<v8::Value>& info); Database() : ObjectWrap() { } bool Cleanup(); -------------- next part -------------- HTML����������������������������... URL: https://lists.osdn.me/mailman/archives/groonga-commit/attachments/20170906/582cdde5/attachment-0001.htm
