[Groonga-commit] groonga/fluent-plugin-groonga at 14102ae [master] test out: use more meaningful test names

Back to archive index

Kouhei Sutou null+****@clear*****
Tue Jan 16 09:19:30 JST 2018


Kouhei Sutou	2018-01-16 09:19:30 +0900 (Tue, 16 Jan 2018)

  New Revision: 14102ae93cb9a7b245ca3a5fbbf5739a1a1289f7
  https://github.com/groonga/fluent-plugin-groonga/commit/14102ae93cb9a7b245ca3a5fbbf5739a1a1289f7

  Message:
    test out: use more meaningful test names

  Modified files:
    test/test_output.rb

  Modified: test/test_output.rb (+19 -6)
===================================================================
--- test/test_output.rb    2018-01-16 09:15:17 +0900 (124ae79)
+++ test/test_output.rb    2018-01-16 09:19:30 +0900 (fd7442a)
@@ -92,7 +92,7 @@ EOC
     end
 
     class CommandTest < self
-      def test_basic_command
+      def test_command_name_position_tag
         @response_body = JSON.generate([[0, 0.0, 0.0], true])
         driver = create_driver
         time = event_time("2012-10-26T08:45:42Z")
@@ -103,12 +103,18 @@ EOC
                      @request_parser.request_url)
       end
 
-      def test_basic_command_with_command_format_record
+      def test_command_name_position_record
         @response_body = JSON.generate([[0, 0.0, 0.0], true])
         driver = create_driver
         time = event_time("2012-10-26T08:45:42Z")
         driver.run(default_tag: "groonga.command") do
-          driver.feed(time, {"name" => "table_create", "arguments" => {"name" => "Users"}})
+          driver.feed(time,
+                      {
+                        "name" => "table_create",
+                        "arguments" => {
+                          "name" => "Users",
+                        },
+                      })
         end
         assert_equal("/d/table_create?name=Users",
                      @request_parser.request_url)
@@ -238,7 +244,7 @@ EOC
     end
 
     class CommandTest < self
-      def test_basic_command
+      def test_command_name_position_tag
         driver = create_driver
         time = event_time("2012-10-26T08:45:42Z")
         driver.run(default_tag: "groonga.command.table_create") do
@@ -257,11 +263,18 @@ EOC
                        actual_input,
                      ])
       end
-      def test_basic_command_with_command_format_record
+
+      def test_command_name_position_record
         driver = create_driver
         time = event_time("2012-10-26T08:45:42Z")
         driver.run(default_tag: "groonga.command") do
-          driver.feed(time, {"name" => "table_create", "arguments" => {"name" => "Users"}})
+          driver.feed(time,
+                      {
+                        "name" => "table_create",
+                        "arguments" => {
+                          "name" => "Users",
+                        },
+                      })
         end
         assert_equal([
                        [
-------------- next part --------------
HTML����������������������������...
URL: https://lists.osdn.me/mailman/archives/groonga-commit/attachments/20180116/b254c451/attachment-0001.htm 



More information about the Groonga-commit mailing list
Back to archive index