[Groonga-mysql-commit] mroonga/mroonga at a055e99 [master] Remove needless workaround for 0 value

Back to archive index

Kouhei Sutou null+****@clear*****
Wed Nov 8 23:49:54 JST 2017


Kouhei Sutou	2017-11-08 23:49:54 +0900 (Wed, 08 Nov 2017)

  New Revision: a055e992925bba2bef566d8008d18d995f689896
  https://github.com/mroonga/mroonga/commit/a055e992925bba2bef566d8008d18d995f689896

  Message:
    Remove needless workaround for 0 value
    
    Groonga already has 0 value indexing support.

  Modified files:
    ha_mroonga.cpp

  Modified: ha_mroonga.cpp (+0 -10)
===================================================================
--- ha_mroonga.cpp    2017-10-26 18:38:47 +0900 (aa293dd9)
+++ ha_mroonga.cpp    2017-11-08 23:49:54 +0900 (9b5fd380)
@@ -6209,16 +6209,6 @@ int ha_mroonga::storage_write_row(uchar *buf)
       }
       grn_obj_set_value(ctx, column, record_id, &value, GRN_OBJ_SET);
     } else {
-      if (added && is_grn_zero_column_value(column, &colbuf)) {
-        // WORKAROUND: groonga can't index newly added '0' value for
-        // fix size column. So we add non-'0' value first then add
-        // real '0' value again. It will be removed when groonga
-        // supports 'null' value.
-        char *bytes = GRN_BULK_HEAD(&colbuf);
-        bytes[0] = '\1';
-        grn_obj_set_value(ctx, column, record_id, &colbuf, GRN_OBJ_SET);
-        bytes[0] = '\0';
-      }
       grn_obj_set_value(ctx, column, record_id, &colbuf, GRN_OBJ_SET);
     }
     if (ctx->rc) {
-------------- next part --------------
HTML����������������������������...
URL: https://lists.osdn.me/mailman/archives/groonga-mysql-commit/attachments/20171108/0019f76c/attachment.htm 



More information about the Groonga-mysql-commit mailing list
Back to archive index