Ticket #41479

Purge of ANGBAND_DIR_DEBUG_SAVE for non-Windows systems

Open Date: 2021-02-06 06:21 Last Update: 2021-02-07 18:38

Reporter:
Owner:
Type:
Status:
Closed
Component:
(None)
Priority:
3
Severity:
3
Resolution:
Fixed
File:
None

Details

Recent changes to src/main/angband-initializer.c include code to purge old entries from ANGBAND_DIR_DEBUG. That code appears to be Windows-specific and does not compile on macOS.

This commit, https://osdn.net/projects/hengbandforosx/scm/git/hengbandosx/commits/bcd48d9ec0ea82ef0e45dcd283985bec5176eb4a , (unix-debug-save-purge branch on the hengbandforosx project; branch is based off Hengband's develop branch) brackets the Windows-specific code with "#ifdef WINDOWS" and adds a Unix-specific implementation in the "#else" clause.

Ticket History (3/4 Histories)

2021-02-06 06:21 Updated by: backwardseric
  • New Ticket "Purge of ANGBAND_DIR_DEBUG_SAVE for non-Windows systems" created
2021-02-06 08:12 Updated by: backwardseric
Comment

Two follow-up commits on the same branch, https://osdn.net/projects/hengbandforosx/scm/git/hengbandosx/commits/f92080b275de8e848e1c72bca1b24014b7c95d7d and https://osdn.net/projects/hengbandforosx/scm/git/hengbandosx/commits/9ebca88726d9c5dcc38c4ba749593c6e5884a0e0 (the latter is the head of the branch), correct two deficiencies with the original:

  • Was not initializing default_savefile on non-Windows systems.
  • Was only passing the last part of the path and not the full path to stat() and remove().

This all relates to the changes in your feature/Fix-Delete-Logfile branch. I don't know if my branch will merge cleanly with that one.

2021-02-06 13:11 Updated by: habu
  • Owner Update from (None) to habu
  • Resolution Update from None to Fixed
Comment

I've merged your commits into the feature/Debug-save-for-non-Windows branch and made a minor fix to the path generation part. This branch will be merged into develop.

I think the feature/Fix-Delete-Logfile will be discarded.

Thanks for your implementation.

2021-02-07 18:38 Updated by: deskull
Comment

解決しているようですので閉じます。

Attachment File List

No attachments

Edit

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Login