• R/O
  • SSH
  • HTTPS

kazehakase: Commit


Commit MetaInfo

Revision3869 (tree)
Time2009-10-04 10:39:33
Authorikezoe

Log Message

* Use g_value_dup_object instead of g_object_ref and g_value_get_object.

Change Summary

Incremental Difference

--- kazehakase/trunk/src/kz-tab-label.c (revision 3868)
+++ kazehakase/trunk/src/kz-tab-label.c (revision 3869)
@@ -405,7 +405,7 @@
405405 switch (prop_id)
406406 {
407407 case PROP_KZ_WINDOW:
408- tablabel->kz = g_object_ref(g_value_get_object(value));
408+ tablabel->kz = g_value_dup_object(value);
409409 break;
410410 case PROP_KZ_WEB:
411411 kz_tab_label_set_web(tablabel, g_value_get_object(value));
--- kazehakase/trunk/src/kz-feed-info.c (revision 3868)
+++ kazehakase/trunk/src/kz-feed-info.c (revision 3869)
@@ -76,7 +76,7 @@
7676 switch (prop_id)
7777 {
7878 case PROP_KZ_WINDOW:
79- info->kz = g_object_ref(g_value_get_object(value));
79+ info->kz = g_value_dup_object(value);
8080 break;
8181 default:
8282 G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);
--- kazehakase/trunk/src/dialogs/kz-copy-format-dialog.c (revision 3868)
+++ kazehakase/trunk/src/dialogs/kz-copy-format-dialog.c (revision 3869)
@@ -290,7 +290,7 @@
290290 switch (prop_id)
291291 {
292292 case PROP_PARENT_WINDOW:
293- copy_format->parent_window = g_object_ref(g_value_get_object(value));
293+ copy_format->parent_window = g_value_dup_object(value);
294294 break;
295295 default:
296296 G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
--- kazehakase/trunk/src/dialogs/kz-prompt-dialog.c (revision 3868)
+++ kazehakase/trunk/src/dialogs/kz-prompt-dialog.c (revision 3869)
@@ -374,9 +374,7 @@
374374 case PROP_PARENT_WINDOW:
375375 if (priv->parent_window)
376376 g_object_unref(priv->parent_window);
377- priv->parent_window = g_value_get_object(value);
378- if (priv->parent_window)
379- g_object_ref(priv->parent_window);
377+ priv->parent_window = g_value_dup_object(value);
380378 break;
381379 default:
382380 G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
--- kazehakase/trunk/src/dialogs/kz-password-manager-dialog.c (revision 3868)
+++ kazehakase/trunk/src/dialogs/kz-password-manager-dialog.c (revision 3869)
@@ -258,7 +258,7 @@
258258 switch (prop_id)
259259 {
260260 case PROP_PARENT_WINDOW:
261- password_manager->parent_window = g_object_ref(g_value_get_object(value));
261+ password_manager->parent_window = g_value_dup_object(value);
262262 break;
263263 default:
264264 G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
--- kazehakase/trunk/src/dialogs/kz-print-dialog.c (revision 3868)
+++ kazehakase/trunk/src/dialogs/kz-print-dialog.c (revision 3869)
@@ -332,7 +332,7 @@
332332 switch (prop_id)
333333 {
334334 case PROP_PARENT_WINDOW:
335- print->parent_window = g_object_ref(g_value_get_object(value));
335+ print->parent_window = g_value_dup_object(value);
336336 break;
337337 default:
338338 G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
--- kazehakase/trunk/src/sidebar/kz-thumbnails-sidebar.c (revision 3868)
+++ kazehakase/trunk/src/sidebar/kz-thumbnails-sidebar.c (revision 3869)
@@ -191,7 +191,7 @@
191191 switch (prop_id)
192192 {
193193 case PROP_SIDEBAR:
194- sidebar->sidebar = g_object_ref(g_value_get_object(value));
194+ sidebar->sidebar = g_value_dup_object(value);
195195 break;
196196 default:
197197 G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
--- kazehakase/trunk/src/sidebar/kz-bookmarks-sidebar.c (revision 3868)
+++ kazehakase/trunk/src/sidebar/kz-bookmarks-sidebar.c (revision 3869)
@@ -149,7 +149,7 @@
149149 switch (prop_id)
150150 {
151151 case PROP_SIDEBAR:
152- sidebar->sidebar = g_object_ref(g_value_get_object(value));
152+ sidebar->sidebar = g_value_dup_object(value);
153153 break;
154154 default:
155155 G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
--- kazehakase/trunk/src/sidebar/kz-downloader-sidebar.c (revision 3868)
+++ kazehakase/trunk/src/sidebar/kz-downloader-sidebar.c (revision 3869)
@@ -338,7 +338,7 @@
338338 switch (prop_id)
339339 {
340340 case PROP_SIDEBAR:
341- sidebar->sidebar = g_object_ref(g_value_get_object(value));
341+ sidebar->sidebar = g_value_dup_object(value);
342342 break;
343343 default:
344344 G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
--- kazehakase/trunk/src/sidebar/kz-tabtree.c (revision 3868)
+++ kazehakase/trunk/src/sidebar/kz-tabtree.c (revision 3869)
@@ -369,7 +369,7 @@
369369 switch (prop_id)
370370 {
371371 case PROP_SIDEBAR:
372- tabtree->sidebar = g_object_ref(g_value_get_object(value));
372+ tabtree->sidebar = g_value_dup_object(value);
373373 break;
374374 case PROP_TREE:
375375 tabtree->tree = g_value_get_boolean(value);
--- kazehakase/trunk/src/kz-statusbar.c (revision 3868)
+++ kazehakase/trunk/src/kz-statusbar.c (revision 3869)
@@ -238,7 +238,7 @@
238238 switch (prop_id)
239239 {
240240 case PROP_KZ_WINDOW:
241- priv->kz = g_object_ref(g_value_get_object(value));
241+ priv->kz = g_value_dup_object(value);
242242 break;
243243 default:
244244 G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);
--- kazehakase/trunk/src/bookmarks/kz-smart-bookmark.c (revision 3868)
+++ kazehakase/trunk/src/bookmarks/kz-smart-bookmark.c (revision 3869)
@@ -164,7 +164,7 @@
164164 g_value_get_pointer(value));
165165 break;
166166 case PROP_SMART_HISTORY:
167- priv->history = g_object_ref(g_value_get_object(value));
167+ priv->history = g_value_dup_object(value);
168168 break;
169169 default:
170170 G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);
--- kazehakase/trunk/src/bookmarks/kz-bookmark-editor.c (revision 3868)
+++ kazehakase/trunk/src/bookmarks/kz-bookmark-editor.c (revision 3869)
@@ -288,10 +288,8 @@
288288 {
289289 case PROP_ROOT_FOLDER:
290290 if (editor->root_folder)
291- {
292291 g_object_unref(editor->root_folder);
293- }
294- editor->root_folder = g_object_ref(g_value_get_object(value));
292+ editor->root_folder = g_value_dup_object(value);
295293
296294 kz_bookmark_editor_set_folder_tree(editor);
297295 kz_bookmark_editor_set_bookmark_tree(editor, editor->root_folder);
--- kazehakase/trunk/src/bookmarks/kz-bookmark-item.c (revision 3868)
+++ kazehakase/trunk/src/bookmarks/kz-bookmark-item.c (revision 3869)
@@ -372,10 +372,10 @@
372372 switch (prop_id)
373373 {
374374 case PROP_BOOKMARK:
375- menu->bookmark = g_object_ref(g_value_get_object(value));
375+ menu->bookmark = g_value_dup_object(value);
376376 break;
377377 case PROP_KZ_WINDOW:
378- menu->kz = g_object_ref(g_value_get_object(value));
378+ menu->kz = g_value_dup_object(value);
379379 break;
380380 default:
381381 G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
--- kazehakase/trunk/src/bookmarks/kz-bookmark-bar.c (revision 3868)
+++ kazehakase/trunk/src/bookmarks/kz-bookmark-bar.c (revision 3869)
@@ -252,10 +252,10 @@
252252 switch (prop_id)
253253 {
254254 case PROP_KZ_WINDOW:
255- bar->kz = g_object_ref(g_value_get_object(value));
255+ bar->kz = g_value_dup_object(value);
256256 break;
257257 case PROP_BOOKMARK_LIST:
258- bar->folder = g_object_ref(g_value_get_object(value));
258+ bar->folder = g_value_dup_object(value);
259259 kz_bookmark_bar_connect_signal(bar);
260260 break;
261261 default:
--- kazehakase/trunk/src/bookmarks/kz-proxy-folder.c (revision 3868)
+++ kazehakase/trunk/src/bookmarks/kz-proxy-folder.c (revision 3869)
@@ -187,7 +187,7 @@
187187 switch (prop_id)
188188 {
189189 case PROP_KZ_BOOKMARK_FOLDER:
190- priv->folder = g_object_ref(g_value_get_object(value));
190+ priv->folder = g_value_dup_object(value);
191191 break;
192192 default:
193193 G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
--- kazehakase/trunk/src/bookmarks/kz-bookmark-base-menu-item.c (revision 3868)
+++ kazehakase/trunk/src/bookmarks/kz-bookmark-base-menu-item.c (revision 3869)
@@ -161,10 +161,10 @@
161161 switch (prop_id)
162162 {
163163 case PROP_BOOKMARK:
164- menu->bookmark = g_object_ref(g_value_get_object(value));
164+ menu->bookmark = g_value_dup_object(value);
165165 break;
166166 case PROP_KZ_WINDOW:
167- menu->kz = g_object_ref(g_value_get_object(value));
167+ menu->kz = g_value_dup_object(value);
168168 break;
169169 default:
170170 G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
--- kazehakase/trunk/src/kz-popup-tablist.c (revision 3868)
+++ kazehakase/trunk/src/kz-popup-tablist.c (revision 3869)
@@ -160,7 +160,7 @@
160160 switch (prop_id)
161161 {
162162 case PROP_KZ_WINDOW:
163- priv->kz = g_object_ref(g_value_get_object(value));
163+ priv->kz = g_value_dup_object(value);
164164 break;
165165 default:
166166 G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
--- kazehakase/trunk/src/kz-sidebar.c (revision 3868)
+++ kazehakase/trunk/src/kz-sidebar.c (revision 3869)
@@ -182,7 +182,7 @@
182182 switch (prop_id)
183183 {
184184 case PROP_KZ_WINDOW:
185- sidebar->kz = g_object_ref(g_value_get_object(value));
185+ sidebar->kz = g_value_dup_object(value);
186186 break;
187187 default:
188188 G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
--- kazehakase/trunk/src/kz-notebook.c (revision 3868)
+++ kazehakase/trunk/src/kz-notebook.c (revision 3869)
@@ -159,7 +159,7 @@
159159 switch (prop_id)
160160 {
161161 case PROP_KZ_WINDOW:
162- priv->kz = g_object_ref(g_value_get_object(value));
162+ priv->kz = g_value_dup_object(value);
163163 break;
164164 default:
165165 G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);
--- kazehakase/trunk/src/kz-download-box.c (revision 3868)
+++ kazehakase/trunk/src/kz-download-box.c (revision 3869)
@@ -141,7 +141,7 @@
141141 switch (prop_id)
142142 {
143143 case PROP_KZ_WINDOW:
144- dlbox->kz = g_object_ref(g_value_get_object(value));
144+ dlbox->kz = g_value_dup_object(value);
145145 break;
146146 default:
147147 G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
--- kazehakase/trunk/src/actions/kz-smart-bookmark-folder-action.c (revision 3868)
+++ kazehakase/trunk/src/actions/kz-smart-bookmark-folder-action.c (revision 3869)
@@ -175,10 +175,10 @@
175175 switch (prop_id)
176176 {
177177 case PROP_KZ_WINDOW:
178- action->kz = g_object_ref(g_value_get_object(value));
178+ action->kz = g_value_dup_object(value);
179179 break;
180180 case PROP_KZ_BOOKMARK:
181- action->bookmark = g_object_ref(g_value_get_object(value));
181+ action->bookmark = g_value_dup_object(value);
182182 break;
183183 case PROP_TEXT:
184184 g_free(action->text);
--- kazehakase/trunk/src/actions/kz-smart-bookmark-button-action.c (revision 3868)
+++ kazehakase/trunk/src/actions/kz-smart-bookmark-button-action.c (revision 3869)
@@ -148,10 +148,10 @@
148148 switch (prop_id)
149149 {
150150 case PROP_BOOKMARK:
151- action->bookmark = g_object_ref(g_value_get_object(value));
151+ action->bookmark = g_value_dup_object(value);
152152 break;
153153 case PROP_KZ_WINDOW:
154- action->kz = g_object_ref(g_value_get_object(value));
154+ action->kz = g_value_dup_object(value);
155155 break;
156156 default:
157157 G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
--- kazehakase/trunk/src/actions/kz-location-entry-action.c (revision 3868)
+++ kazehakase/trunk/src/actions/kz-location-entry-action.c (revision 3869)
@@ -177,12 +177,12 @@
177177 switch (prop_id)
178178 {
179179 case PROP_KZ_WINDOW:
180- action->kz = g_object_ref(g_value_get_object(value));
180+ action->kz = g_value_dup_object(value);
181181 break;
182182 case PROP_KZ_BOOKMARK:
183183 if (action->bookmark)
184184 g_object_unref(action->bookmark);
185- action->bookmark = g_object_ref(g_value_get_object(value));
185+ action->bookmark = g_value_dup_object(value);
186186 break;
187187 default:
188188 G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
--- kazehakase/trunk/src/actions/kz-zoom-action.c (revision 3868)
+++ kazehakase/trunk/src/actions/kz-zoom-action.c (revision 3869)
@@ -119,7 +119,7 @@
119119 switch (prop_id)
120120 {
121121 case PROP_KZ_WINDOW:
122- priv->kz = g_object_ref(g_value_get_object(value));
122+ priv->kz = g_value_dup_object(value);
123123 break;
124124 default:
125125 G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
--- kazehakase/trunk/src/actions/kz-smart-bookmark-action.c (revision 3868)
+++ kazehakase/trunk/src/actions/kz-smart-bookmark-action.c (revision 3869)
@@ -196,10 +196,10 @@
196196 switch (prop_id)
197197 {
198198 case PROP_KZ_WINDOW:
199- action->kz = g_object_ref(g_value_get_object(value));
199+ action->kz = g_value_dup_object(value);
200200 break;
201201 case PROP_KZ_BOOKMARK:
202- action->bookmark = g_object_ref(g_value_get_object(value));
202+ action->bookmark = g_value_dup_object(value);
203203 /* if bookmark is a folder, connect signals */
204204 if (kz_bookmark_is_folder(action->bookmark))
205205 {
--- kazehakase/trunk/src/actions/kz-stop-reload-action.c (revision 3868)
+++ kazehakase/trunk/src/actions/kz-stop-reload-action.c (revision 3869)
@@ -137,7 +137,7 @@
137137 switch (prop_id)
138138 {
139139 case PROP_KZ_WINDOW:
140- priv->kz = g_object_ref(g_value_get_object(value));
140+ priv->kz = g_value_dup_object(value);
141141 break;
142142 case PROP_STATE:
143143 priv->state = g_value_get_int(value);
--- kazehakase/trunk/src/actions/kz-navigation-action.c (revision 3868)
+++ kazehakase/trunk/src/actions/kz-navigation-action.c (revision 3869)
@@ -111,7 +111,7 @@
111111 switch (prop_id)
112112 {
113113 case PROP_KZ_WINDOW:
114- action->kz = g_object_ref(g_value_get_object(value));
114+ action->kz = g_value_dup_object(value);
115115 break;
116116 default:
117117 G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
--- kazehakase/trunk/ChangeLog (revision 3868)
+++ kazehakase/trunk/ChangeLog (revision 3869)
@@ -1,5 +1,9 @@
11 2009-10-03 Hiroyuki Ikezoe <poincare@ikezoe.net>
22
3+ * Use g_value_dup_object instead of g_object_ref and g_value_get_object.
4+
5+2009-10-03 Hiroyuki Ikezoe <poincare@ikezoe.net>
6+
37 * src/kz-web.c: Implement missin kz_web_get_dest_anchors().
48
59 2009-09-29 Hiroyuki Ikezoe <poincare@ikezoe.net>
Show on old repository browser