Masahiko Sawada
sawad****@gmail*****
2015年 8月 13日 (木) 16:08:15 JST
On Thu, Aug 13, 2015 at 2:27 PM, <ishii****@nttda*****> wrote: > Hi all, > > Attached patch adds regression tests. > This patch include 3 tests. Thank you for the patch! > > 1) make installcheck > -ludia_funcs has only regression test for pgs2snippet1(). > This patch adds test for pgs2norm(). > 2) make installcheck-textporter > -This is test for textporter. > User who want to use ludia_funcs together with textporter will conduct this test. > User has to install textporter before testing. The both #1 and #2 regression test seems not to work fine in my environment, which doesn't have postgres user. > 3) make installcheck-debug-option > -This is test for internal operation. > User who want to use ludia_funcs together with textporter will conduct this test. > Before testing, user has to install textporter, and compile ludia_funcs with debug option. > ex) make USE_PGXS=1 SENNA_CFG=*** TEXTPORTER=*** CFLAGS=-DPGS2_DEBUG Regression test is done successfully. > > This patch includes binary file (git diff --binary). > Please apply patch using "git apply". > ex) git apply --whitespace=nowarn ../ludia_funcs_regress.patch > I have applied this patch without ERROR, but I think it would be better to separate these regression test into different patches. The followings are first review comment. ludia_funcs.sql and debug-option.sql have extra new lines at very bottom of itself. Why did you add DROP EXTENSION ludia_funcs; into sql file? Could you explain about the reason why we need to create new database for textporter regression test in textporter.sql? Regards, -- Masahiko Sawada
Fork