Add regression tests (Ludiafuncs-hackers) - Ludia functions

> -----Original Message-----
> From: ludia****@lists*****
> [mailto:ludia****@lists*****] On Behalf Of
> ishii****@nttda*****
> Sent: Monday, August 24, 2015 3:09 PM
> To: ludia****@lists*****
> Subject: Re: [Ludiafuncs-hackers] Add regression tests
> 
> Thank you for review.
> I updated the patch.
> 
> > > Changes from the last time:
> > > ・Delete unnecessary "CREATE USER"
> > >   (We use "CREATE USER" only when we create normal user.)
> >
> > You can use SET ROLE and RESET ROLE command in order to do permission
> > test, instead of adding textporter-close test.
> 
> I fixed to use SET ROLE instead of textporter-close test.
> 
> > > expected/ludia_funcs.out:789: trailing whitespace.
> > > +\c euc_db
> > > expected/ludia_funcs.out:795: trailing whitespace.
> > > +\c contrib_regression
> > > sql/ludia_funcs.sql:176: trailing whitespace.
> > > +\c euc_db
> > > sql/ludia_funcs.sql:180: trailing whitespace.
> > > +\c contrib_regression
> >
> > There are some unnecessary trailing whitespaces in
> > 000_ludia_funcs_regress.patch as follows.
> 
> I fixed to delete unnecessary trailing whitespaces.
> 
> > > $ patch -d. -p1 <
> >
> > ../patch/ludia_funcs_regress_patch/001_ludia_funcs_regress_debug_opt
> > io
> > > n.patch
> > > patching file Makefile
> > > Hunk #1 FAILED at 33.
> > > 1 out of 1 hunk FAILED -- saving rejects to file Makefile.rej
> > I could not apply 001_ludia_funcs_regress_debug_option.patch
> > successfully.
> >
> > It looks like both file debug_option.patch and textporter.patch have
> > wrong prefix number each other.
> > debug_options patch should be applied after textporter patch applied.
> 
> I fixed the number.
> ・000_ludia_funcs_regress.patch
> ・001_ludia_funcs_regress_textporter.patch
> ・002_ludia_funcs_regress_debug_option.patch
> 
> In addition, I made test for all utf8.

Thank you for update the patch.

*** /opt/ludia_funcs/expected/ludia_funcs.out      2015-08-24 14:55:24.247002838 +0900
--- /opt /ludia_funcs/results/ludia_funcs.out       2015-08-24 15:29:34.308002956 +0900
***************
*** 803,808 ****
  SELECT * FROM pgs2norm('abc');
  ERROR:  does not support database encoding "EUC_JP"
  SELECT pgs2snippet1(1,300,1,'∇','∇',0,'エおA','あイうエおａbｃdｅかキくケこjｋlｍn');
! ERROR:  invalid byte sequence for encoding "EUC_JP": 0xe2 0x88
  \c contrib_regression
  DROP DATABASE euc_db;
--- 803,808 ----
  SELECT * FROM pgs2norm('abc');
  ERROR:  does not support database encoding "EUC_JP"
  SELECT pgs2snippet1(1,300,1,'∇','∇',0,'エおA','あイうエおａbｃdｅかキくケこjｋlｍn');
! ERROR:  invalid byte sequence for encoding "EUC_JP": 0xe288
  \c contrib_regression
  DROP DATABASE euc_db;
======================================================================

I got this difference with installcheck regression test on PostgreSQL 9.1.
The above seems to be emitted due to that query has multi byte characters which are out of range of EUC-JP encoding.
Do you have solutions?

Regards,

--------
Sawada Masahiko

Ludia functions Forkludia_funcssenna-1.1.2-fast

[Ludiafuncs-hackers] Add regression tests

Ludia functions
Fork
ludia_funcs
senna-1.1.2-fast