Fujii Masao
masao****@gmail*****
2015年 9月 2日 (水) 12:30:45 JST
On Mon, Aug 31, 2015 at 6:01 PM, Fujii Masao <masao****@gmail*****> wrote: > On Mon, Aug 31, 2015 at 5:44 PM, Fujii Masao <masao****@gmail*****> wrote: >> On Fri, Aug 28, 2015 at 2:14 PM, Fujii Masao <masao****@gmail*****> wrote: >>> On Mon, Aug 24, 2015 at 3:09 PM, <ishii****@nttda*****> wrote: >>>> ・001_ludia_funcs_regress_textporter.patch >> >> Attached is the updated version of the patch which provides >> the regression tests for pgs2textporter1 function. >> Could you review this version? > > +SELECT pgs2textporter1('/home/postgres/pgsql/fts/ludia_funcs/data/test.docx'); > > The heading part of the argument in this function should be > @abs_srcdir @ . So I updated the patch again so that @abs_srcdir@ > is used instead. ushed the modified version of the patch. Could you review this change? BTW, I added the regression tests checking the case where textporter_option is set to an invalid value because it's interpreted in ludia_funcs unlike other parameters (they are interpreted in PostgreSQL). Regards, -- Fujii Masao