ForkHi,
When I ran "installcheck-bigm" tests on PostgreSQL which block size was
configured to 16KB, the test failed.
The difference is as follows:
$ cat regression.diffs
diff -U3 /home/tori/ludia_funcs/expected/pg_bigm.out
/home/tori/ludia_funcs/results/pg_bigm.out
--- /home/tori/ludia_funcs/expected/pg_bigm.out 2020-02-07
10:54:51.638653784 +0900
+++ /home/tori/ludia_funcs/results/pg_bigm.out 2020-02-07
16:34:31.995833532 +0900
@@ -1074,8 +1074,6 @@
LOG: pgs2norm(): complete (set result cache): 東京都
LOG: pgs2malloc(): buflen 2048, needed 46, maxlen 4194304
LOG: pgs2norm(): complete (set result cache): 東京都山田太郎
-LOG: pgs2malloc(): buflen 2048, needed 22, maxlen 4194304
-LOG: pgs2norm(): complete (set result cache): 東京都
LOG: pgs2malloc(): buflen 2048, needed 48, maxlen 4194304
LOG: pgs2norm(): complete (set result cache): 東京都 山田太郎
LOG: pgs2malloc(): buflen 2048, needed 48, maxlen 4194304
@@ -1090,6 +1088,8 @@
LOG: pgs2norm(): complete (set result cache): 東京都 山田太郎
LOG: pgs2malloc(): buflen 2048, needed 34, maxlen 4194304
LOG: pgs2norm(): complete (set result cache): 東京と京都
+LOG: pgs2malloc(): buflen 2048, needed 22, maxlen 4194304
+LOG: pgs2norm(): complete (set result cache): 東京都
It failed at this query:
---sql/pg_bigm.sql
387 -- Test whether recheck is skipped expectedly when keyword length
is 1 or 2
388 SET ludia_funcs.enable_debug TO on;
389 SELECT col1 FROM text_tbl
390 WHERE pgs2norm(col1) LIKE likequery(pgs2norm('東京都')) ORDER BY
col1;
It seems that the order of rechecking data has changed after block size
was configured to 16KB.
As the comment says, the purpose of this test is to ensure 'whether
recheck is skipped expectedly'.
If so, the order of rechecking is not important and we want to know just
the recheck was done or not.
Fujii-san said the current debug option was too detailed for this test
and advised me to add 'terse' option for just logging the function had
called.
I agree with this idea and attached a patch.
Could you review it when it's convenient
for you?
Regards,
Torikoshi Atsushi
-------------- next part --------------
テキスト形式以外の添付ファイルを保管しました...
ファイル名: enable_debug_to_terse.patch
型: text/x-diff
サイズ: 10783 バイト
説明: 無し
URL: <https://lists.osdn.me/mailman/archives/ludiafuncs-hackers/attachments/20200219/3d8e72dc/attachment.patch>