Thanks for your kind review! Attached a fixed patch. On 2020-02-20 01:46, Fujii Masao wrote: > Could you tell me why you used "completed" instead of "complete" when > "terse" is specified? IMO it's better to use the same word in both > "on" and "terse" cases. You're right. I've changed "completed" to "complete". I intended to be consistent with pgs2malloc() log message which used past tense 'called', but this message was added in this patch. Should I also fix this message? If so, I'll also fix it. However, it’s just me but I feel a little bit strange to change "called" to "call" here. | elog(LOG, "pgs2malloc(): called"); BTW, I found the usage 'called' in PostgreSQL. | CatalogCacheFlushCatalog(Oid catId) | ... | CACHE2_elog(DEBUG2, | "CatalogCacheFlushCatalog called for %u", catId); Regards, Torikoshi Atsushi -------------- next part -------------- テキスト形式以外の添付ファイルを保管しました... ファイル名: enable_debug_to_terse_v2.patch 型: text/x-diff サイズ: 11663 バイト 説明: 無し URL: <https://lists.osdn.me/mailman/archives/ludiafuncs-hackers/attachments/20200220/64f2ed77/attachment.patch>
Fork