On 2020/02/26 11:16, torikoshia wrote: > Thanks for reviewing! > > On 2020-02-25 15:46, Fujii Masao wrote: > >> Or what about just reporting "pgs2malloc()" for >> the consistency with the detailed information of log? > > That sounds appropriate for this situation. > > >> Your patch seems to forget to treat the following log message. >> >> elog(LOG, "GetSennaQuery(): quick exit: %s", tmp); > > Oops, I've added 'terse' condition to GetSennaQuery(). > > >> I think that it's better to comment the reason why 'terse' is enough >> for this regression test. So I'd like to add something like the following >> comments based on the comments that you added. Thought? > > Thanks for rewriting the comments! > It seems much better than mine. > > > Attached an updated patch. Thanks for updating the patch! I reworked the patch a bit and then pushed it. Regards, -- Fujii Masao NTT DATA CORPORATION Advanced Platform Technology Group Research and Development Headquarters
Fork