• R/O
  • HTTP
  • SSH
  • HTTPS

pg_hint_plan: Commit

firtst release


Commit MetaInfo

Revision0136339dced7e5c611703b91b22895bee7f64afa (tree)
Time2020-02-13 14:52:46
AuthorKyotaro Horiguchi <horikyota.ntt@gmai...>
CommiterKyotaro Horiguchi

Log Message

Do null-check of error_context_stack before use

The variable is accessed without null checking when planner is called
in the context of pl/pgsql. Fix it. Back-patched up to pg_hint_plan94.

Reporter: egashira-yusuke
Issue: https://github.com/ossc-db/pg_hint_plan/issues/42
Original-Author: sun-wei <30999182+Dagouhan@users.noreply.github.com>
Original-patch: https://github.com/ossc-db/pg_hint_plan/pull/45/commits/8fe092ef73a9af6cfb41e20717d7cb35aa74fce2

Change Summary

Incremental Difference

--- a/pg_hint_plan.c
+++ b/pg_hint_plan.c
@@ -3010,7 +3010,8 @@ pg_hint_plan_planner(Query *parse, int cursorOptions, ParamListInfo boundParams)
30103010 * Support for nested plpgsql functions. This is quite ugly but this is the
30113011 * only point I could find where I can get the query string.
30123012 */
3013- if (plpgsql_recurse_level > 0)
3013+ if (plpgsql_recurse_level > 0 &&
3014+ error_context_stack && error_context_stack->arg)
30143015 {
30153016 MemoryContext oldcontext;
30163017
Show on old repository browser