• R/O
  • HTTP
  • SSH
  • HTTPS

pg_hint_plan: Commit

firtst release


Commit MetaInfo

Revision1d935d6269fa811dd39f07bd95989c692f80bc79 (tree)
Time2019-03-08 14:04:33
AuthorKyotaro Horiguchi <horiguchi.kyotaro@lab....>
CommiterKyotaro Horiguchi

Log Message

Silence some compilers

Some compilers seem to complain about the previous patch, that
prev_hint_str is used uninitialized. Actually it is not but move the
initialization code out of the PG_TRY() section so that such compilers
would be quiet.

Change Summary

Incremental Difference

--- a/pg_hint_plan.c
+++ b/pg_hint_plan.c
@@ -3078,19 +3078,19 @@ pg_hint_plan_planner(Query *parse, int cursorOptions, ParamListInfo boundParams)
30783078 }
30793079
30803080 /*
3081+ * The planner call below may replace current_hint_str. Store and restore
3082+ * it so that the subsequent planning in the upper level doesn't get
3083+ * confused.
3084+ */
3085+ recurse_level++;
3086+ prev_hint_str = current_hint_str;
3087+
3088+ /*
30813089 * Use PG_TRY mechanism to recover GUC parameters and current_hint_state to
30823090 * the state when this planner started when error occurred in planner.
30833091 */
30843092 PG_TRY();
30853093 {
3086- /*
3087- * The planner call below may replace current_hint_str. Store and
3088- * restore it so that the subsequent planning in the upper level
3089- * doesn't get confused.
3090- */
3091- recurse_level++;
3092- prev_hint_str = current_hint_str;
3093-
30943094 if (prev_planner)
30953095 result = (*prev_planner) (parse, cursorOptions, boundParams);
30963096 else
Show on old repository browser