• R/O
  • HTTP
  • SSH
  • HTTPS

pg_hint_plan: Commit

firtst release


Commit MetaInfo

Revision53c74fbab9c703f31f57f84f85b11017f94277fb (tree)
Time2020-02-13 14:51:51
AuthorKyotaro Horiguchi <horikyota.ntt@gmai...>
CommiterKyotaro Horiguchi

Log Message

Do null-check of error_context_stack before use

The variable is accessed without null checking when planner is called
in the context of pl/pgsql. Fix it. Back-patched up to pg_hint_plan94.

Reporter: egashira-yusuke
Issue: https://github.com/ossc-db/pg_hint_plan/issues/42
Original-Author: sun-wei <30999182+Dagouhan@users.noreply.github.com>
Original-patch: https://github.com/ossc-db/pg_hint_plan/pull/45/commits/8fe092ef73a9af6cfb41e20717d7cb35aa74fce2

Change Summary

Incremental Difference

--- a/pg_hint_plan.c
+++ b/pg_hint_plan.c
@@ -2693,7 +2693,8 @@ pg_hint_plan_planner(Query *parse, int cursorOptions, ParamListInfo boundParams)
26932693 * Support for nested plpgsql functions. This is quite ugly but this is the
26942694 * only point I could find where I can get the query string.
26952695 */
2696- if (plpgsql_recurse_level > 0)
2696+ if (plpgsql_recurse_level > 0 &&
2697+ error_context_stack && error_context_stack->arg)
26972698 {
26982699 MemoryContext oldcontext;
26992700
Show on old repository browser