• R/O
  • HTTP
  • SSH

pg_hint_plan: List of commits

firtst release

Rev. Time Author
1d86d3b PG10 2020-02-17 21:08:15 Kyotaro Horiguchi

Restore current hint state when returned from non-hinted query planning.

If no hint is given for the current level query, pg_hint_plan_planner
calls the next level of planner after erasing the
current_hint_state. But it forgot to restore the state before the
planning of the rest part of the current-level query. It is
(a-kind-of) broken by the commit d422966 but overlooked as an
inevitable side-effect of the fix. Get back the behavior by restoring
current_hint_state after returned from the lower level planner with
unhinted query.

Issue: https://github.com/ossc-db/pg_hint_plan/issues/30
Reported-by: higuchi-daisuke

ef5e864 2020-02-17 16:56:35 Kyotaro Horiguchi

Use proper type for non-integer GUC options.

pg_hint_plan internally preserved numeric options into integer
variable regardless of their types, which leads to unintentional
change of the values. Handle double values in the proper way.

ffc2832 2020-02-17 15:00:43 Kyotaro Horiguchi

Fix Rows hint parsing

This is a long standing bug that Rows hint with no parameter causees a
crash. Fixed the Rows hint parser.

788cf4b 2020-02-17 13:45:33 Kyotaro Horiguchi

Give correct query location to generate_normalized_query.

There was a thinko about query_loc of generate_normalized_query which
causes a crash. For example a query is following a sequence of
semicolons (by \; in psql input) longer than the length after the last
placeholder to the end of the query, the function causes assertion
failure. Anyway prepared statements lose that value so we just pass 0
as the query_loc for consistent behavior.

ca7d497 2020-02-14 16:31:26 Kyotaro Horiguchi

Fix crash bug caused by plancache invalidation


After plancache is invalidated then revaliated, get_query_string
accesses query_list of invalid plansource then crash. Ignore invalid
plancache and get the correct hint string and Query node at the next
planning time during revalidation.

On the way fixing this, a bug related to planner reentrance is
fixed. That fix causes behavioral change for nested
planning. Previously outer-level hint (wrongly) overrides inner-level
query but currenlty outer-level hint no longer affects inner-level

eb2d8f3 2020-02-14 16:31:26 Kyotaro Horiguchi

Fix behavior of nested planning

Issue: https://github.com/ossc-db/pg_hint_plan/issues/39

When planning is nested by function call, the hints in the function
should affect the corresponding query. Maybe 9599067 introduced
that. Fix the nested planning behavior.

26d0dec 2020-02-14 16:22:20 Kyotaro Horiguchi

Don't leave partial paths when no parallel hint is specified

pg_hint_plan_set_rel_pathlist left partial paths if no parallel hint
is specified, but that behavior leaves indexscan partial paths on
restricted indexes. Remove all partial paths unconditionally.

b526f32 2020-02-13 20:42:45 Junseok Yang

Use tuple-only mode to stablize EXPLAIN output containing @abs_srcdir@.

The line containing @abs_srcdir@ can be longer than the header line
and if it is, the test will fail. Use tuple-only mode to get rid of
the unstable part from the EXPLAIN output.

24d844e 2020-02-13 15:50:38 Kyotaro Horiguchi

Stabilize regression test.

Further unstability is found about stats reset. Inserted more 1 second
sleeps to stabilize it.

987abe5 2020-02-13 14:52:33 Kyotaro Horiguchi

Do null-check of error_context_stack before use

The variable is accessed without null checking when planner is called
in the context of pl/pgsql. Fix it. Back-patched up to pg_hint_plan94.

Reporter: egashira-yusuke
Issue: https://github.com/ossc-db/pg_hint_plan/issues/42
Original-Author: sun-wei <30999182+Dagouhan@users.noreply.github.com>
Original-patch: https://github.com/ossc-db/pg_hint_plan/pull/45/commits/8fe092ef73a9af6cfb41e20717d7cb35aa74fce2

64fe767 2019-08-29 17:23:26 Jignesh Shah

Fix is_dummy_rel based on changes in PostgreSQL 10.8

This breaks compatibility with older minor versions, but don't bother
keeping it. Binary built using newer PG minor versions works for older
minor versions.

31d93fe 2019-08-29 16:57:12 LittleWuCoding

fix spelling mistakes in file pg_hint_plan.html

d9bc761 2019-08-29 16:12:39 Arthur Zakirov

Use ParallelHint in ParallelHintCreate()

b8f3e8a 2019-03-08 14:05:11 Kyotaro Horiguchi

Silence some compilers

Some compilers seem to complain about the previous patch, that
prev_hint_str is used uninitialized. Actually it is not but move the
initialization code out of the PG_TRY() section so that such compilers
would be quiet.

647bad4 2019-02-26 17:49:50 Kyotaro Horiguchi

Correctly handle planner nesting

pg_hint_plan assumed that plpgsql is the only source of nested planner
calls. Actually nested call can be made in any shapes. Most of the
cases doesn't harm but in a special case where pg_dbms_stats makes a
SPI call during query planning, that affects subsequent planner
work. Hints lose effect when pg_dbms_stats searches "locked
statistics" tables while planning the target query.

8cc5d96 2019-02-26 17:48:41 Kyotaro Horiguchi

Follow the behavior change of PostgreSQL

Some behavioral changes of PostgreSQL breaks regression test. Follow
the changes.

429bd37 REL10_1_3_3 2019-01-17 16:40:44 Kyotaro Horiguchi

Change version to 1.3.3

Version bumped to 1.3.3. SPEC file is updated.

6d9f890 2019-01-17 16:40:44 Kyotaro Horiguchi

Fix reverse link of hint_list.html

pg_hint_plan.html and hint_list.html pointed to the Japanese version
of main document. Fixed it.

e1a859e 2019-01-17 16:24:57 Kyotaro Horiguchi

Fix documentation.

Fixed wrong or stale descriptions, and poor or broken styles of
the documentation.

92610f1 2019-01-17 13:14:24 Kyotaro Horiguchi

Do make install for rpmbuild

Use make install to build in prmbuild directory instaed of using
install command to individual file to reduce maintenance labor.

edafe89 2019-01-17 13:05:02 Kyotaro Horiguchi

Include all pg_hint_plan--*.sql files in installation

Glob installation/upgrade SQL scripts instead of spcifying
individually to reduce maintenance labor.

3f87702 2019-01-17 13:03:01 Kyotaro Horiguchi

Change copyright year to 2019

bc7aa65 2019-01-09 09:58:21 Kyotaro Horiguchi

Call standrad_ProcessUtility when no hook is set

The last commit 3cb8d0b forgot the case of no previous hook function
in the ProcessUtility hook function. Fix it.

3cb8d0b 2019-01-07 19:08:05 Kyotaro Horiguchi

Support prepared statements on extended protocol

However pg_hint_plan doesn't fully consider the extended protocol,
commit c05bb31 accidentially broke the case where an analyzed prepared
statement is executed on extended protocol. This patch fixes that only
for the hints-in-comment case. Hint-table still doesn't work in the
case since query-normalization needs Query, which is not available in

eb5f0ea 2019-01-07 19:08:05 Kyotaro Horiguchi

Remove an useless variable

commit c05bb31 made the variable stmt_name useless. Remove it.

0eda42b 2018-12-05 17:31:53 Kyotaro Horiguchi

Fix for union-on-inheritance case

setup_hint_enforcement may pick up a wrong hint when multiple
subqueries access inheritance tables. This leads to failure to apply
hints on other than the first subquery.

c9864a4 2018-12-05 17:31:48 Kyotaro Horiguchi

Don't reset plpgsql nest level at every command end

Clean up code for global exit is forgetting about loops that run
hinted commands multiple times. This leads to pg_hint_plan's failure
to affect after the first execution of the inner commands.
The hint below worked only for the first time.

FOR outer IN EXECUTE 'outer-command' LOOP
FOR inner IN EXECUTE '/*+ hint */ inner-command' LOOP

0160295 REL10_1_3_2 2018-11-13 17:39:33 Kyotaro Horiguchi

Changed version to 1.3.2

Previously parse_messages and message_level were binded to the same
internal variable. Separate the two GUCs. On the way doing this some
mssages that did not honor the variable were fixed. Default behavior
is not changed but the the two variables works differently from the
previous version, perhaps closer to expected.

f287a17 2018-11-13 17:39:33 Kyotaro Horiguchi

Remove unnecessary file

Commit c7888a1 added wrong file. Remove it.

f5de55b 2018-11-13 17:39:33 Kyotaro Horiguchi

Fix regression test following core's behavior

Some changes has been made on GUC default value and behavior. Follow
the change. No change was made on pg_hint_plan's behavior.

Show on old repository browser