• R/O
  • HTTP
  • SSH

pg_hint_plan: List of commits

firtst release

Rev. Time Author
904a4fc PG11 2022-03-09 12:18:23 Kyotaro Horiguchi

Ignore non-existent prepared statement in get_query_string.

CREATE FUNCTION of SQL function uses post_parse_analyze_hook during
validation. If the function contained EXECUTE <prepared statement>,
not only that statement may be nonexistent, but also there's no need
of the query string at that point.

Since execution of nonexistent prepared statement ends with failure
sooner or later, we can safely ignore that.

Backpatch to pg_hint_plan10 that are before the core's EOL.

a797bcf REL11_1_3_7 2020-10-29 21:12:16 Kyotaro Horiguchi

Change version to 1.3.7.

Fixed bogus upgrade scripts on the way changing version.

0fe2760 2020-10-29 21:12:16 Kyotaro Horiguchi

Make HashJoin hint more coercive.

Even with HashJoin hint, hash joins may be rejected by planner if hash
table for the inner-rel is estimated too large. Make HashJoin hint
more coercive by temporarily increasing work_mem. This change affects
only join-searching so no significant side-effects are expected.

01adeac 2020-10-29 21:12:16 Kyotaro Horiguchi

Fix tested OS version to CentOS 8.2

e600d83 2020-10-29 21:12:16 Kyotaro Horiguchi

Change copyright year of docs to 2020

7a9a406 2020-10-29 20:29:28 Kyotaro Horiguchi

Stabilize regression test.

I was annoyed by frequent nonsubstantial change of title line length
of explain output. This commit makes maskout.sh replace the title
lines with fixed content.

634d207 2020-10-29 20:29:28 Kyotaro Horiguchi

Follow a behavioral change in core.

Commit 3737965249 has changed the core's behavior of naming indexes.
Follow the changes. This is regression-result changes only.

4343403 2020-10-29 20:29:28 Kyotaro Horiguchi

Update core.c and make_join_rel.c.

From this version core.c and make_join_rel.c are automatically
generated from core code. Adjust them to auto-generated content.

d0e413c 2020-10-29 20:29:28 Kyotaro Horiguchi

New tool to generate source files for copied functions

Previously core.c and make_join_rel.c are maintained by hand. This
tool generates the files from corresponding core source files.

7b86e22 REL11_1_3_6 2020-08-05 16:07:45 Kyotaro Horiguchi

Version 1.3.6

Fixed some bugs.

f8754a6 2020-07-14 18:10:01 sherlockcpp

Add description of *ScanRegExp hints in the document.

English version of hint list is missing regexp versions of scan
hints. Add them.

d1c0dbd 2020-07-14 17:33:08 Daniil Anisimov

Fix segfault when use Set, Rows and Parallel hints together

08addd1 2020-07-14 16:33:06 Yang Rong

Fix some spelling errors in comments

fe9017f 2020-07-14 16:18:44 LucyLikeMilk

Fix version number in upgrade script.

pg_hint_plan--1.3.3-1.3.4.sql has a wrong signature in comments. Fix

3080222 2020-07-14 15:01:58 egashira.yusuke

Mark hint table as a configuration table.

The table hint_plan.hints is a configuration table of
pg_hint_plan. Mark it as such, as well as its sequence table.

Back patch to pg_hint_plan96.

10efd8a REL11_1_3_5 2020-02-20 21:56:30 Kyotaro Horiguchi

Change version to 1.3.5.

75ac46e 2020-02-20 19:58:27 Kyotaro Horiguchi

Change copyright year to 2020.

a9bcfa7 2020-02-17 21:08:03 Kyotaro Horiguchi

Restore current hint state when returned from non-hinted query planning.

If no hint is given for the current level query, pg_hint_plan_planner
calls the next level of planner after erasing the
current_hint_state. But it forgot to restore the state before the
planning of the rest part of the current-level query. It is
(a-kind-of) broken by the commit d422966 but overlooked as an
inevitable side-effect of the fix. Get back the behavior by restoring
current_hint_state after returned from the lower level planner with
unhinted query.

Issue: https://github.com/ossc-db/pg_hint_plan/issues/30
Reported-by: higuchi-daisuke

f204d75 2020-02-17 17:49:55 Kyotaro Horiguchi

Follow the core chnges.

Update core.c following the changes in the core. It makes difference
in the regression test result so update it, too.

0087813 2020-02-17 16:56:14 Kyotaro Horiguchi

Use proper type for non-integer GUC options.

pg_hint_plan internally preserved numeric options into integer
variable regardless of their types, which leads to unintentional
change of the values. Handle double values in the proper way.

f5ba122 2020-02-17 15:03:59 Kyotaro Horiguchi

Fix Rows hint parsing

This is a long standing bug that Rows hint with no parameter causees a
crash. Fixed the Rows hint parser.

64249fb 2020-02-17 13:44:33 Kyotaro Horiguchi

Give correct query location to generate_normalized_query.

There was a thinko about query_loc of generate_normalized_query which
causes a crash. For example a query is following a sequence of
semicolons (by \; in psql input) longer than the length after the last
placeholder to the end of the query, the function causes assertion
failure. Anyway prepared statements lose that value so we just pass 0
as the query_loc for consistent behavior.

be1a68f 2020-02-14 15:57:39 Kyotaro Horiguchi

Fix crash bug caused by plancache invalidation

Issue: https://github.com/ossc-db/pg_hint_plan/issues/41

After plancache is invalidated then revaliated, get_query_string
accesses query_list of invalid plansource then crash. Ignore invalid
plancache and get the correct hint string and Query node at the next
planning time during revalidation.

On the way fixing this, a bug related to planner reentrance is
fixed. That fix causes behavioral change for nested
planning. Previously outer-level hint (wrongly) overrides inner-level
query but currenlty outer-level hint no longer affects inner-level

4e3c987 2020-02-14 15:57:35 Kyotaro Horiguchi

Fix behavior of nested planning

Issue: https://github.com/ossc-db/pg_hint_plan/issues/39

When planning is nested by function call, the hints in the function
should affect the corresponding query. Maybe 9599067 introduced
that. Fix the nested planning behavior.

7d35d75 2020-02-14 15:54:13 Kyotaro Horiguchi

Fix a typo.

bf5a325 2020-02-13 20:39:39 Junseok Yang

Use tuple-only mode to stablize EXPLAIN output containing @abs_srcdir@.

The line containing @abs_srcdir@ can be longer than the header line
and if it is, the test will fail. Use tuple-only mode to get rid of
the unstable part from the EXPLAIN output.

92039c6 2020-02-13 20:01:25 LittleWuCoding

Fix compiling error on Solaris

The 'LDFLAGS+=-Wl,--build-id' option is for rpm building in Linux like
OS. The SunOS is not native support the option
'LDFLAGS+=-Wl,--build-id' . So, we disable this option in SunOS while

Committed a bit tweaked version from the orignal.

a47f7ee 2020-02-13 15:43:19 Kyotaro Horiguchi

Stabilize regression test.

Further unstability is found about stats reset. Inserted more 1 second
sleeps to stabilize it.

0136339 2020-02-13 14:52:46 Kyotaro Horiguchi

Do null-check of error_context_stack before use

The variable is accessed without null checking when planner is called
in the context of pl/pgsql. Fix it. Back-patched up to pg_hint_plan94.

Reporter: egashira-yusuke
Issue: https://github.com/ossc-db/pg_hint_plan/issues/42
Original-Author: sun-wei <30999182+Dagouhan@users.noreply.github.com>
Original-patch: https://github.com/ossc-db/pg_hint_plan/pull/45/commits/8fe092ef73a9af6cfb41e20717d7cb35aa74fce2

dba2113 2019-08-29 17:33:54 Jignesh Shah

Fix definition of is_dummy_rel based on changes to community PostgreSQL 11.3

This breaks compatibility with older minor versions, but don't bother
keeping it. Binary built using newer PG minor versions works for older
minor versions.

Show on old repository browser