WebSVN layout change
mateuszviste patch applied. I don't like this svn viewer very much, I find it not very intuitive, but it was the only one I could find that was pure PHP without dependencies. but it works, and is not worse than the thing proposed by OSDN. :)
Does the patch work for you? I don't see a difference in log view. On http://svn.svardos.org/log.php?repname=SvarDOS "diff" is still the right-most column.
mateuszviste I didn't check honestly, only applied your patch on the server. Looking now I see that apparently the column's headers are not consistent with what is under them. The column "diff" is the rightmost one, but under it are log messages, while the diff buttons are under the column "log message".
Stupid me! I mentioned the BlueGrey template (theme), but patched the Elegant template. :-(
I'll look into it and come back with a proper patch.
New try:
diff -aprNU5 --binary websvn-2.6.1-orig/templates/BlueGrey/log.tmpl websvn-2.6.1/templates/BlueGrey/log.tmpl
--- websvn-2.6.1-orig/templates/BlueGrey/log.tmpl Wed May 12 13:33:14 2021
+++ websvn-2.6.1/templates/BlueGrey/log.tmpl Mon Feb 28 11:45:37 2022
@@ -52,12 +52,12 @@
<tr>
<th>[lang:REV]</th>
<th>[lang:AGE]</th>
<th>[lang:AUTHOR]</th>
<th>[lang:PATH]</th>
- <th>[lang:LOGMSG]</th>
<th>[lang:DIFF]</th>
+ <th>[lang:LOGMSG]</th>
[websvn-test:showchanges]
<th>[lang:CHANGES]</th>
[websvn-endtest]
</tr>
</thead>
@@ -69,12 +69,12 @@
[websvn-else]
<td title="[websvn:revage]">[websvn:revdate]</td>
[websvn-endtest]
<td>[websvn:revauthor]</td>
<td>[websvn:revpathlink]</td>
- <td valign="top">[websvn:revlog]</td>
<td><a href="[websvn:compareurl]" title="[lang:DIFFPREV]">[lang:DIFF]</a></td>
+ <td valign="top">[websvn:revlog]</td>
[websvn-test:showchanges]
<td class="changes"><table>
[websvn-test:revadded]
<tr><td>A</td><td>[websvn:revadded]</td></tr>
[websvn-endtest]
mateuszviste applied
Thanks! Works for me. :-)
Maybe you want to either remove the incomplete patch for the Elegant template now or fix it.
Here is a diff in addition to my first patch from 18 Feb 2022:
diff -aprNU5 --binary websvn-2.6.1-orig/templates/Elegant/log.tmpl websvn-2.6.1/templates/Elegant/log.tmpl
--- websvn-2.6.1-orig/templates/Elegant/log.tmpl Mon Feb 28 14:39:17 2022
+++ websvn-2.6.1/templates/Elegant/log.tmpl Mon Feb 28 14:38:42 2022
@@ -75,12 +75,12 @@
<th>[lang:AGE]</th>
<!-- <th>[lang:DATE]</th> Note: [lang:DATE] doesn't exist yet... -->
[websvn-endtest]
<th>[lang:AUTHOR]</th>
<th>[lang:PATH]</th>
- <th>[lang:LOGMSG]</th>
<th>[lang:DIFF]</th>
+ <th>[lang:LOGMSG]</th>
[websvn-test:showchanges]
<th>[lang:CHANGES]</th>
[websvn-endtest]
</tr>
</thead>
And for the 'calm' template:
diff -aprNU5 --binary websvn-2.6.1-orig/templates/calm/log.tmpl websvn-2.6.1/templates/calm/log.tmpl
--- websvn-2.6.1-orig/templates/calm/log.tmpl Wed May 12 05:33:14 2021
+++ websvn-2.6.1/templates/calm/log.tmpl Mon Feb 28 14:44:13 2022
@@ -67,12 +67,12 @@
<tr>
<th class="HdrClmn">[lang:REV]</th>
<th class="HdrClmn">[lang:AGE]</th>
<th class="HdrClmn">[lang:AUTHOR]</th>
<th class="HdrClmn">[lang:PATH]</th>
- <th class="HdrClmnEnd">[lang:LOGMSG]</th>
<th class="HdrClmn">[lang:DIFF]</th>
+ <th class="HdrClmnEnd">[lang:LOGMSG]</th>
[websvn-test:showchanges]
<th class="HdrClmnEnd">[lang:CHANGES]</th>
[websvn-endtest]
</tr>
</thead>
@@ -84,12 +84,12 @@
[websvn-else]
<td class="date" title="[websvn:revage]">[websvn:revdate]</td>
[websvn-endtest]
<td>[websvn:revauthor]</td>
<td>[websvn:revpathlink]</td>
- <td valign="middle" class="logmsg">[websvn:revlog]</td>
<td><span class="diff"><a href="[websvn:compareurl]" title="[lang:DIFFPREV]"> </a></span></td>
+ <td valign="middle" class="logmsg">[websvn:revlog]</td>
[websvn-test:showchanges]
<td class="changes">
[websvn-test:revadded]
<div class="add">[websvn:revadded]</div>
[websvn-endtest]
My preferred template on this SVN is BlueGrey.
But I noticed all templates suffer the same problem: The diff column is the right-most column. Some log messages are shorter, some are longer. So, I find it hard to click the line for the correct diff.
Would you please do me a favor and switch log messages and diff columns? Should be as simple as:
diff -aprNU5 --binary websvn-2.6.1-orig/templates/Elegant/log.tmpl websvn-2.6.1/templates/Elegant/log.tmpl --- websvn-2.6.1-orig/templates/Elegant/log.tmpl Wed May 12 13:33:14 2021 +++ websvn-2.6.1/templates/Elegant/log.tmpl Fri Feb 18 23:49:28 2022 @@ -97,12 +97,12 @@ [websvn-else] <td class="date" title="[websvn:revage]">[websvn:revdate]</td> [websvn-endtest] <td class="author">[websvn:revauthor]</td> <td class="path">[websvn:revpathlink]</td> - <td class="logmsg">[websvn:revlog]</td> <td class="diff"><a href="[websvn:compareurl]" title="[lang:DIFFPREV]">[lang:DIFF]</a></td> + <td class="logmsg">[websvn:revlog]</td> [websvn-test:showchanges] <td class="changes"><table> [websvn-test:revadded] <tr><td class="add">[websvn:revadded]</td></tr> [websvn-endtest]