May 25, 2018 updates: Privacy Policy
  • R/O
  • SSH
  • HTTPS

tortoisesvn: Commit


Commit MetaInfo

Revision28199 (tree)
Time2018-04-21 16:37:02
Authorstefankueng

Log Message

Return early in case of an error, do not try to access the invalid hash.

Change Summary

Incremental Difference

--- trunk/src/SVN/SVN.cpp (revision 28198)
+++ trunk/src/SVN/SVN.cpp (revision 28199)
@@ -262,6 +262,9 @@
262262 subpool, subpool),
263263 NULL
264264 );
265+ if (Err)
266+ return false;
267+
265268 apr_hash_index_t *hi;
266269 for (hi = apr_hash_first(subpool, names_hash); hi; hi = apr_hash_next(hi))
267270 {
@@ -270,7 +273,7 @@
270273 }
271274 std::sort(Names.begin(), Names.end());
272275
273- return (Err == NULL);
276+ return (Err == nullptr);
274277 }
275278
276279 bool SVN::Checkout(const CTSVNPath& moduleName, const CTSVNPath& destPath, const SVNRev& pegrev,
--- trunk/src/Changelog.txt (revision 28198)
+++ trunk/src/Changelog.txt (revision 28199)
@@ -3,6 +3,8 @@
33 dialogs. (Stefan)
44 - BUG: Shelving from TSVN dialogs returned
55 an error. (Stefan)
6+- BUG: Crash when trying to unshelve from
7+ an outdated or corrupted working copy. (Stefan)
68
79 Version 1.10.0
810 See the release notes here:
Show on old repository browser