• R/O
  • SSH
  • HTTPS

tortoisesvn: Commit


Commit MetaInfo

Revision28570 (tree)
Time2019-05-03 01:47:30
Authorstefankueng

Log Message

Check for a valid canonicalized url before attempting to use it.

Change Summary

Incremental Difference

--- trunk/src/Changelog.txt (revision 28569)
+++ trunk/src/Changelog.txt (revision 28570)
@@ -1,4 +1,8 @@
1-Version 1.12.0
1+Version 1.12.1
2+- BUG: Crash in the repo browser if externals
3+ with relative paths were present. (Stefan)
4+
5+Version 1.12.0
26 - BUG: Ignoring comments in TMerge could
37 lead to memory exhaustion. (Stefan)
48
--- trunk/src/Utils/PathUtils.cpp (revision 28569)
+++ trunk/src/Utils/PathUtils.cpp (revision 28570)
@@ -460,8 +460,10 @@
460460 const char *canonicalized_url = nullptr;
461461 svn_error_clear(svn_uri_canonicalize_safe(&canonicalized_url, nullptr, URL, pool, pool));
462462
463- if (svn_path_is_url (canonicalized_url))
463+ if (canonicalized_url && svn_path_is_url (canonicalized_url))
464464 return canonicalized_url;
465+ if (canonicalized_url == nullptr)
466+ canonicalized_url = URL;
465467
466468 /* Parse the parent directory URL into its parts. */
467469
Show on old repository browser