• R/O
  • SSH
  • HTTPS

tortoisesvn: Commit


Commit MetaInfo

Revision28712 (tree)
Time2020-01-09 04:59:51
Authorstefankueng

Log Message

Prevent an error leak

Change Summary

Incremental Difference

--- trunk/src/SVN/SVN.cpp (revision 28711)
+++ trunk/src/SVN/SVN.cpp (revision 28712)
@@ -359,14 +359,17 @@
359359 // revert the shelved files so they appear as not modified
360360 Err = svn_client__shelf_unapply(new_version, false, subpool);
361361 }
362- svn_string_t* propval = svn_string_create((LPCSTR)CUnicodeUtils::GetUTF8(logMsg), subpool);
363-
364- apr_hash_t* revprop_table = apr_hash_make(subpool);
365- apr_hash_set(revprop_table, SVN_PROP_REVISION_LOG, APR_HASH_KEY_STRING, propval);
366- Err = svn_client__shelf_revprop_set_all(shelf, revprop_table, subpool);
367362 if (Err == nullptr)
368363 {
369- Err = svn_client__shelf_close(shelf, subpool);
364+ svn_string_t* propval = svn_string_create((LPCSTR)CUnicodeUtils::GetUTF8(logMsg), subpool);
365+
366+ apr_hash_t* revprop_table = apr_hash_make(subpool);
367+ apr_hash_set(revprop_table, SVN_PROP_REVISION_LOG, APR_HASH_KEY_STRING, propval);
368+ Err = svn_client__shelf_revprop_set_all(shelf, revprop_table, subpool);
369+ if (Err == nullptr)
370+ {
371+ Err = svn_client__shelf_close(shelf, subpool);
372+ }
370373 }
371374 }
372375 }
Show on old repository browser