• R/O
  • SSH
  • HTTPS

tortoisesvn: Commit


Commit MetaInfo

Revision29516 (tree)
Time2022-12-25 23:12:24
Authordanielsahlberg

Log Message

Make error overlay more consistent:
- In MarkAlAsRead and MonitorShowProject, also look at lastErrorMessage in determining if there should be an exclamation mark
- In ClearErrors, hardcode overlay 0 as we just set pItem->authFailed to false above

Change Summary

Incremental Difference

--- trunk/src/TortoiseProc/LogDialog/LogDlg.cpp (revision 29515)
+++ trunk/src/TortoiseProc/LogDialog/LogDlg.cpp (revision 29516)
@@ -8597,7 +8597,7 @@
85978597 pItem->unreadItems = 0;
85988598 pItem->unreadFirst = 0;
85998599 m_projTree.SetItemState(hLocalItem, pItem->unreadItems ? TVIS_BOLD : 0, TVIS_BOLD);
8600- m_projTree.SetItemState(hLocalItem, pItem->authFailed ? INDEXTOOVERLAYMASK(OVERLAY_MODIFIED) : 0, TVIS_OVERLAYMASK);
8600+ m_projTree.SetItemState(hLocalItem, (pItem->authFailed || !pItem->lastErrorMsg.IsEmpty()) ? INDEXTOOVERLAYMASK(OVERLAY_MODIFIED) : 0, TVIS_OVERLAYMASK);
86018601 return false;
86028602 });
86038603
@@ -8618,7 +8618,7 @@
86188618 MonitorItem* pItem = reinterpret_cast<MonitorItem*>(m_projTree.GetItemData(hItem));
86198619 pItem->authFailed = false;
86208620 pItem->lastErrorMsg.Empty();
8621- m_projTree.SetItemState(hItem, pItem->authFailed ? INDEXTOOVERLAYMASK(OVERLAY_MODIFIED) : 0, TVIS_OVERLAYMASK);
8621+ m_projTree.SetItemState(hItem, 0, TVIS_OVERLAYMASK);
86228622 return false;
86238623 });
86248624
@@ -9809,7 +9809,7 @@
98099809 new async::CAsyncCall(this, &CLogDlg::LogThread, &netScheduler);
98109810
98119811 m_projTree.SetItemState(hItem, pItem->unreadItems ? TVIS_BOLD : 0, TVIS_BOLD);
9812- m_projTree.SetItemState(hItem, pItem->authFailed ? INDEXTOOVERLAYMASK(OVERLAY_MODIFIED) : 0, TVIS_OVERLAYMASK);
9812+ m_projTree.SetItemState(hItem, (pItem->authFailed || !pItem->lastErrorMsg.IsEmpty()) ? INDEXTOOVERLAYMASK(OVERLAY_MODIFIED) : 0, TVIS_OVERLAYMASK);
98139813 }
98149814
98159815 bool hasUnreadItems = false;
Show on old repository browser