• R/O
  • SSH

zandronum-zdoom-sync: Commit


Commit MetaInfo

Revision25f4891078d548376a40b90fb1ef401304008e4f (tree)
Time2007-10-12 12:26:28
AuthorBrad Carney <bmc431@gmai...>
CommiterBrad Carney

Log Message

- Fixed vulnerability that allowed clients to crash all other clients by saying a chat string with "%n".

SVN r836 (beta4-2_b)

Change Summary

Incremental Difference

diff -r 16cc7cc04634 -r 25f4891078d5 docs/Skulltag Version History.txt
--- a/docs/Skulltag Version History.txt Wed Sep 26 02:53:18 2007 +0000
+++ b/docs/Skulltag Version History.txt Fri Oct 12 03:26:28 2007 +0000
@@ -11,6 +11,11 @@
1111 =
1212 ===============================================================================================================
1313
14+v0.97d-beta4.3
15+--------------
16+
17+*- - Fixed vulnerability that allowed clients to crash all other clients by saying a chat string with "%n". [Carnevil]
18+
1419 v0.97d-beta4.2
1520 --------------
1621
diff -r 16cc7cc04634 -r 25f4891078d5 src/botcommands.cpp
--- a/src/botcommands.cpp Wed Sep 26 02:53:18 2007 +0000
+++ b/src/botcommands.cpp Fri Oct 12 03:26:28 2007 +0000
@@ -599,14 +599,16 @@
599599 //
600600 void BOTCMD_SetLastChatString( char *pszString )
601601 {
602- sprintf( g_szLastChatString, pszString );
602+ strncpy( g_szLastChatString, pszString, 255 );
603+ g_szLastChatString[255] = 0;
603604 }
604605
605606 //*****************************************************************************
606607 //
607608 void BOTCMD_SetLastChatPlayer( char *pszString )
608609 {
609- sprintf( g_szLastChatPlayer, pszString );
610+ strncpy( g_szLastChatPlayer, pszString, 255 );
611+ g_szLastChatPlayer[255] = 0;
610612 }
611613
612614 //*****************************************************************************
diff -r 16cc7cc04634 -r 25f4891078d5 src/version.h
--- a/src/version.h Wed Sep 26 02:53:18 2007 +0000
+++ b/src/version.h Fri Oct 12 03:26:28 2007 +0000
@@ -40,7 +40,7 @@
4040
4141 /** Lots of different version numbers **/
4242
43-#define DOTVERSIONSTR "0.97d-beta4.2"
43+#define DOTVERSIONSTR "0.97d-beta4.3"
4444
4545 // [BB] Define DOTVERSIONSTR_NOREV to stay compatible with IWADBoxCallback in I_system.cpp
4646 #define DOTVERSIONSTR_NOREV DOTVERSIONSTR
@@ -64,7 +64,8 @@
6464 // NETGAMEVERSION 004 = 0.97c3
6565 // NETGAMEVERSION 005 = 0.97d-beta4
6666 // NETGAMEVERSION 006 = 0.97d-beta4.2
67-#define NETGAMEVERSION 006
67+// NETGAMEVERSION 007 = 0.97d-beta4.3
68+#define NETGAMEVERSION 007
6869
6970 // Version stored in the ini's [LastRun] section.
7071 // Bump it if you made some configuration change that you want to
Show on old repository browser