• R/O
  • HTTP
  • SSH
  • HTTPS

Commit

Tags
No Tags

Frequently used words (click to add to your profile)

javaandroidc++linuxc#objective-c誰得cocoaqtpythonrubywindowsphpgameguibathyscaphec翻訳omegat計画中(planning stage)frameworktwitterdombtronvb.nettestarduinodirectxpreviewerゲームエンジン

frameworks/base


Commit MetaInfo

Revisionbdbf96c117553153589086cf29a848accf075a01 (tree)
Time2020-12-21 03:13:27
Authorwilsonshih <wilsonshih@goog...>
CommiterKevin Haggerty

Log Message

Make WallpaperMS bind wallpaper component PendingIntent immutable.

Require that the PendingIntent be immutable so that a malicious app is
not able to hijack and mutate any of the details.

Fixes: 154915372
Test: build & flash, change wallpaper manually.
Change-Id: I59b48811b26736bf0575769107dd940ca33ccf8d
(cherry picked from commit d4bd69cef05d379555418a8fe748ec94ff6bd6d0)
(cherry picked from commit b392903052b3c35b5b9706d6d1f19762d943f58e)

Change Summary

Incremental Difference

--- a/services/core/java/com/android/server/wallpaper/WallpaperManagerService.java
+++ b/services/core/java/com/android/server/wallpaper/WallpaperManagerService.java
@@ -1747,7 +1747,7 @@ public class WallpaperManagerService extends IWallpaperManager.Stub {
17471747 mContext, 0,
17481748 Intent.createChooser(new Intent(Intent.ACTION_SET_WALLPAPER),
17491749 mContext.getText(com.android.internal.R.string.chooser_wallpaper)),
1750- 0, null, new UserHandle(serviceUserId)));
1750+ PendingIntent.FLAG_IMMUTABLE, null, new UserHandle(serviceUserId)));
17511751 if (!mContext.bindServiceAsUser(intent, newConn,
17521752 Context.BIND_AUTO_CREATE | Context.BIND_SHOWING_UI
17531753 | Context.BIND_FOREGROUND_SERVICE_WHILE_AWAKE,