Commit: 215276243d74b89fc8c28509d16dd2a107c65946 - Openssl (git)

TLS/SSL and crypto library

Commit MetaInfo

• Revision: 215276243d74b89fc8c28509d16dd2a107c65946 (tree)
• Time: 2012-03-13 00:25:53
• Author: Dr. Stephen Henson <steve@open...>
• Commiter: Dr. Stephen Henson

Log Message

corrected fix to PR#2711 and also cover mime_param_cmp

Change Summary

• modified: crypto/asn1/asn_mime.c

Incremental Difference

--- a/crypto/asn1/asn_mime.c
+++ b/crypto/asn1/asn_mime.c
@@ -790,9 +790,8 @@ static int mime_hdr_addparam(MIME_HEADER *mhdr, char *name, char *value)
 static int mime_hdr_cmp(const MIME_HEADER * const *a,
 			const MIME_HEADER * const *b)
 {
-	if ((*a)->name == NULL || (*b)->name == NULL)
-		return (*a)->name - (*b)->name < 0 ? -1 :
-			(*a)->name - (*b)->name > 0 ? 1 : 0;
+	if (!(*a)->name || !(*b)->name)
+		return !!(*a)->name - !!(*b)->name;
 
 	return(strcmp((*a)->name, (*b)->name));
 }
@@ -800,6 +799,8 @@ static int mime_hdr_cmp(const MIME_HEADER * const *a,
 static int mime_param_cmp(const MIME_PARAM * const *a,
 			const MIME_PARAM * const *b)
 {
+	if (!(*a)->param_name || !(*b)->param_name)
+		return !!(*a)->param_name - !!(*b)->param_name;
 	return(strcmp((*a)->param_name, (*b)->param_name));
 }