Commit: d990fa155c76fee2a9ef778e335053729b3985fd - BSInlinePreviewer (git)

BathyScapheで画像のインラインプレビューを可能にするプラグイン

Commit MetaInfo

• Revision: d990fa155c76fee2a9ef778e335053729b3985fd (tree)
• Time: 2012-05-20 13:49:39
• Author: masakih <masakih@user...>
• Commiter: masakih

Log Message

[Refactor] NSStringリテラルを一カ所にまとめた

Change Summary

• modified: Ex/BSIPEReplacer.m

Incremental Difference

--- a/Ex/BSIPEReplacer.m
+++ b/Ex/BSIPEReplacer.m
@@ -14,6 +14,12 @@
 - (NSAttributedString *)attachmentAttributedStringWithImage:(NSImage *)image;
 @end
 
+static NSString *BSIPEViewkey = @"BSIPEViewkey";
+static NSString *BSIPERangeKey = @"BSIPERangeKey";
+static NSString *BSIPEImageKey = @"BSIPEImageKey";
+static NSString *BSIPEOffsetKey = @"BSIPEOffsetKey";
+static NSString *BSIPELinkKey = @"BSIPELinkKey";
+
 @interface BSIPEReplacer ()
 // 画像挿入によって引き起こしたNSTextStorageDidProcessEditingNotificationの回数
 @property NSUInteger selfNotified;
@@ -119,10 +125,10 @@ NSRange fixRange(NSRange range, NSTextStorage *ts)
 }
 - (void)insertImage:(NSDictionary *)attr
 {
-	NSTextView *tv = [attr objectForKey:@"View"];
-	NSRange range = NSRangeFromString([attr objectForKey:@"Range"]);
-	id newInsertion = [attr objectForKey:@"Image"];
-	NSUInteger offset = [[attr objectForKey:@"Offset"] unsignedIntegerValue];
+	NSTextView *tv = [attr objectForKey:BSIPEViewkey];
+	NSRange range = NSRangeFromString([attr objectForKey:BSIPERangeKey]);
+	id newInsertion = [attr objectForKey:BSIPEImageKey];
+	NSUInteger offset = [[attr objectForKey:BSIPEOffsetKey] unsignedIntegerValue];
 	range.location += offset;
 	
 	NSTextStorage *ts = [tv textStorage];
@@ -164,8 +170,8 @@ NSRange fixRange(NSRange range, NSTextStorage *ts)
 					usingBlock:^(id value, NSRange range, BOOL *stop) {
 						NSURL *url = [NSURL URLWithString:value];
 						if([self.owner validateLink:url]) {
-							[links addObject:[NSDictionary dictionaryWithObjectsAndKeys:url, @"Link",
-											  NSStringFromRange(range), @"Range", nil]];
+							[links addObject:[NSDictionary dictionaryWithObjectsAndKeys:url, BSIPELinkKey,
+											  NSStringFromRange(range), BSIPERangeKey, nil]];
 						}
 					}];
 		
@@ -175,22 +181,22 @@ NSRange fixRange(NSRange range, NSTextStorage *ts)
 			if(!self.textView) return;
 			
 			id dict = [links objectAtIndex:index];
-			NSRange range = NSRangeFromString([dict objectForKey:@"Range"]);
+			NSRange range = NSRangeFromString([dict objectForKey:BSIPERangeKey]);
 			if([ts attribute:BSInlinePreviewerPreviewed atIndex:range.location longestEffectiveRange:NULL inRange:range]) {
 				return;
 			}
 			// download image.
-			NSImage *image = [self.owner downloadImageURL:[dict objectForKey:@"Link"]];
+			NSImage *image = [self.owner downloadImageURL:[dict objectForKey:BSIPELinkKey]];
 			if(!image) return;
 			
 			id newInsertion = [self.owner attachmentAttributedStringWithImage:image];
 			
 			
 			NSDictionary *attr = [[NSDictionary alloc] initWithObjectsAndKeys:
-								  newInsertion, @"Image",
-								  [dict objectForKey:@"Range"], @"Range",
-								  self.textView, @"View",
-								  [NSNumber numberWithUnsignedInteger:offset], @"Offset",
+								  newInsertion, BSIPEImageKey,
+								  [dict objectForKey:BSIPERangeKey], BSIPERangeKey,
+								  self.textView, BSIPEViewkey,
+								  [NSNumber numberWithUnsignedInteger:offset], BSIPEOffsetKey,
 								  nil];
 			[self performSelectorOnMainThread:@selector(insertImage:) withObject:attr waitUntilDone:NO];
 			offset += [newInsertion length];