• R/O
  • SSH
  • HTTPS

Commit

Tags
No Tags

Frequently used words (click to add to your profile)

javac++androidlinuxc#windowsobjective-ccocoa誰得qtpythonphprubygameguibathyscaphec計画中(planning stage)翻訳omegatframeworktwitterdomtestvb.netdirectxゲームエンジンbtronarduinopreviewer

Commit MetaInfo

Revision154 (tree)
Time2015-12-02 20:36:17
Authort_nakayama1971

Log Message

clear warning

Change Summary

Incremental Difference

--- trunk/plugin/com.sysdeo.eclipse.tomcat/src/com/sysdeo/eclipse/tomcat/TomcatPreferencePage.java (revision 153)
+++ trunk/plugin/com.sysdeo.eclipse.tomcat/src/com/sysdeo/eclipse/tomcat/TomcatPreferencePage.java (revision 154)
@@ -101,8 +101,7 @@
101101 PREF_PAGE_HOME_LABEL, homeGroup);
102102
103103 //blank
104- Label lbl = new Label(composite, SWT.NULL);
105- lbl.setParent(composite);
104+ insertBlank(composite);
106105
107106 Group modeGroup = new Group(composite, SWT.NONE);
108107 modeGroup.setLayout(new GridLayout(1, false));
@@ -118,8 +117,7 @@
118117 configGroup, false);
119118
120119 //blank
121- lbl = new Label(composite, SWT.NULL);
122- lbl.setParent(composite);
120+ insertBlank(composite);
123121
124122 this.configLocationGroup = new Composite(modeGroup, SWT.NULL);
125123 this.configFile = new TomcatFileFieldEditor(
@@ -135,36 +133,53 @@
135133 this.home.setPropertyChangeListener(this);
136134
137135 //blank
138- lbl = new Label(composite, SWT.NULL);
139- lbl.setParent(composite);
136+ insertBlank(composite);
140137
141138 initLayoutAndData(homeGroup, 3);
142139 initLayoutAndData(modeGroup, 1);
143140 initLayoutAndData(this.configLocationGroup, 3);
144141
145- this.initField(this.version);
142+ initializeField();
143+
144+ return composite;
145+ }
146+
147+ /**
148+ * initialize Field
149+ */
150+ private void initializeField() {
151+
152+ initField(this.version);
146153 this.version.setPropertyChangeListener(this);
147154
148- this.initField(this.home);
149- this.initField(this.configMode);
155+ initField(this.home);
156+ initField(this.configMode);
150157 modeChanged(this.configLocationGroup,
151158 getPreferenceStore().getString(TomcatPluginResources.TOMCAT_PREF_CONFMODE_KEY));
152159
153160 this.configMode.setPropertyChangeListener(this);
154161
155- this.initField(this.configFile);
162+ initField(this.configFile);
156163 if (this.configFile.getStringValue().length() == 0) {
157164 computeConfigFile();
158165 }
159- this.initField(this.contextsDir);
166+ initField(this.contextsDir);
160167 if (this.contextsDir.getStringValue().length() == 0) {
161168 computeContextsDir();
162169 }
163170
164- return composite;
165171 }
166172
167173 /**
174+ * create blank
175+ * @param composite Composite
176+ */
177+ private void insertBlank(final Composite composite) {
178+ Label lbl = new Label(composite, SWT.NULL);
179+ lbl.setParent(composite);
180+ }
181+
182+ /**
168183 * @see org.eclipse.jface.util.IPropertyChangeListener#propertyChange(org.eclipse.jface.util.PropertyChangeEvent)
169184 */
170185 @Override