• R/O
  • SSH
  • HTTPS

Commit

Frequently used words (click to add to your profile)

javac++androidlinuxc#windowsobjective-ccocoa誰得qtpythonphprubygameguibathyscaphec計画中(planning stage)翻訳omegatframeworktwitterdomtestvb.netdirectxゲームエンジンbtronarduinopreviewer

OmegaT の背景に画像を表示します。


Commit MetaInfo

Revision60 (tree)
Time2014-05-26 15:13:10
Authoryu-tang

Log Message

refactoring: Effect クラスを Abstract に変更して具象クラスの継承元をそちらに変更し、インターフェイス IEffect を削除

Change Summary

Incremental Difference

--- trunk/src/jp/sourceforge/users/yutang/omegat/plugin/moenizer/ThemeChanger.java (revision 59)
+++ trunk/src/jp/sourceforge/users/yutang/omegat/plugin/moenizer/ThemeChanger.java (revision 60)
@@ -20,7 +20,6 @@
2020 import java.util.List;
2121 import java.util.Map;
2222 import jp.sourceforge.users.yutang.omegat.plugin.moenizer.effect.Effect;
23-import jp.sourceforge.users.yutang.omegat.plugin.moenizer.effect.IEffect;
2423 import org.omegat.util.Log;
2524
2625 /**
@@ -61,7 +60,7 @@
6160
6261 try {
6362 Effect.Type type = (Effect.Type) conf.get("type");
64- IEffect effect = Effect.create(type, conf);
63+ Effect effect = Effect.create(type, conf);
6564 effect.invoke(model);
6665 } catch (Exception ex) {
6766 ex.printStackTrace();
--- trunk/src/jp/sourceforge/users/yutang/omegat/plugin/moenizer/effect/IEffect.java (revision 59)
+++ trunk/src/jp/sourceforge/users/yutang/omegat/plugin/moenizer/effect/IEffect.java (nonexistent)
@@ -1,29 +0,0 @@
1-/**************************************************************************
2- Moenizer - Allow to set background image for OmegaT.
3-
4- Copyright (C) 2014 Yu Tang
5- Home page: http://sourceforge.jp/users/yu-tang/
6- Support center: http://sourceforge.jp/users/yu-tang/pf/Moenizer/
7-
8- This file is part of plugin for OmegaT.
9- http://www.omegat.org/
10-
11- License: GNU GPL version 3 or (at your option) any later version.
12-
13- You should have received a copy of the GNU General Public License
14- along with this program. If not, see <http://www.gnu.org/licenses/>.
15- **************************************************************************/
16-
17-package jp.sourceforge.users.yutang.omegat.plugin.moenizer.effect;
18-
19-import jp.sourceforge.users.yutang.omegat.plugin.moenizer.MoeUI;
20-
21-/**
22- *
23- * @author Yu-Tang
24- */
25-public interface IEffect {
26-
27- public void invoke(MoeUI ui);
28-
29-}
--- trunk/src/jp/sourceforge/users/yutang/omegat/plugin/moenizer/effect/Effect.java (revision 59)
+++ trunk/src/jp/sourceforge/users/yutang/omegat/plugin/moenizer/effect/Effect.java (revision 60)
@@ -17,6 +17,7 @@
1717
1818 import java.lang.reflect.Constructor;
1919 import java.util.Map;
20+import jp.sourceforge.users.yutang.omegat.plugin.moenizer.MoeUI;
2021
2122 /**
2223 * static method only
@@ -23,24 +24,25 @@
2324 *
2425 * @author Yu-Tang
2526 */
26-public class Effect {
27+public abstract class Effect {
2728
28- private Effect() {
29- // prevent instantiation
30- }
31-
3229 public enum Type {
3330 BasicEffect
3431 }
3532
36- public static IEffect create(Type type, Map conf) throws Exception {
33+ public static Effect create(Type type, Map conf) throws Exception {
3734 final String CLASS_NAME = Effect.class.getPackage().getName() + "." + type.name();
38- Class<? extends IEffect> clazz = (Class<? extends IEffect>) Class.forName(CLASS_NAME);
35+ Class<? extends Effect> clazz = (Class<? extends Effect>) Class.forName(CLASS_NAME);
3936 Class<?>[] types = {Map.class};
40- Constructor<? extends IEffect> constructor = clazz.getConstructor(types);
37+ Constructor<? extends Effect> constructor = clazz.getConstructor(types);
4138 Object[] args = {conf};
42- IEffect newInstance = constructor.newInstance(args);
39+ Effect newInstance = constructor.newInstance(args);
4340 return newInstance;
4441 }
4542
43+ protected <T> T get(String key, Map<String, Object> config, T valueDefault) {
44+ return config.containsKey(key) ? (T) config.get(key) : valueDefault;
45+ }
46+
47+ public abstract void invoke(MoeUI ui);
4648 }
--- trunk/src/jp/sourceforge/users/yutang/omegat/plugin/moenizer/effect/BasicEffect.java (revision 59)
+++ trunk/src/jp/sourceforge/users/yutang/omegat/plugin/moenizer/effect/BasicEffect.java (revision 60)
@@ -33,7 +33,7 @@
3333 *
3434 * @author Yu-Tang
3535 */
36-public class BasicEffect implements IEffect {
36+public class BasicEffect extends Effect {
3737
3838 private final String KEY_TARGET = "target";
3939 private final String KEY_OPACITY = "opacity";
@@ -56,10 +56,6 @@
5656 exclude = get(KEY_EXCLUDE, config, exclude);
5757 }
5858
59- private <T> T get(String key, Map<String, Object> config, T valueDefault) {
60- return config.containsKey(key) ? (T) config.get(key) : valueDefault;
61- }
62-
6359 @Override
6460 public void invoke(MoeUI ui) {
6561 if (image.isEmpty()) {