[Groonga-commit] groonga/groonga at 11ae6ba [master] dump: fix a bug that wrong table type is dumped

Back to archive index

Kouhei Sutou null+****@clear*****
Sat Aug 3 19:28:15 JST 2013


Kouhei Sutou	2013-08-03 19:28:15 +0900 (Sat, 03 Aug 2013)

  New Revision: 11ae6bacdbb519f079f54329ed153fb21f0b86cb
  https://github.com/groonga/groonga/commit/11ae6bacdbb519f079f54329ed153fb21f0b86cb

  Message:
    dump: fix a bug that wrong table type is dumped
    
    It is caused by the following conditions:
    
      * Table type is TABLE_PAT_KEY
      * Key is reference type
    
    This fix the following test failure:
    
        [3] table/patricia_trie
          reference_key                                                 0.0368s [failed]
        ================================================================================
        --- (expected)
        +++ (actual)
        @@ -4,5 +4,5 @@
         [[0,0.0,0.0],true]
         dump
         table_create Names TABLE_PAT_KEY ShortText
        -table_create Users TABLE_PAT_KEY Names
        +table_create Users TABLE_HASH_KEY Names

  Modified files:
    lib/proc.c

  Modified: lib/proc.c (+0 -3)
===================================================================
--- lib/proc.c    2013-08-03 19:05:44 +0900 (34320f2)
+++ lib/proc.c    2013-08-03 19:28:15 +0900 (181dc1a)
@@ -2347,9 +2347,6 @@ dump_table(grn_ctx *ctx, grn_obj *outbuf, grn_obj *table,
   case GRN_TABLE_PAT_KEY:
   case GRN_TABLE_DAT_KEY:
     domain = grn_ctx_at(ctx, table->header.domain);
-    if (domain) {
-      default_flags |= domain->header.flags;
-    }
     break;
   default:
     break;
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Back to archive index