Kouhei Sutou
null+****@clear*****
Fri Oct 27 18:11:31 JST 2017
Kouhei Sutou 2017-10-27 18:11:31 +0900 (Fri, 27 Oct 2017) New Revision: da9f890b4a044900517c9b2aec009ca0c1acde95 https://github.com/ranguba/groonga-client/commit/da9f890b4a044900517c9b2aec009ca0c1acde95 Message: Use meaningful name Modified files: lib/groonga/client/command-line/groonga-client-index-check.rb Modified: lib/groonga/client/command-line/groonga-client-index-check.rb (+11 -11) =================================================================== --- lib/groonga/client/command-line/groonga-client-index-check.rb 2017-10-27 18:10:09 +0900 (e8edb7a) +++ lib/groonga/client/command-line/groonga-client-index-check.rb 2017-10-27 18:11:31 +0900 (fe75411) @@ -30,7 +30,7 @@ module Groonga def run(arguments) parser = Parser.new - indexes = parser.parse(arguments) do |option_parser| + indexe_names = parser.parse(arguments) do |option_parser| parse_command_line(option_parser) end @@ -39,7 +39,7 @@ module Groonga end parser.open_client do |client| - checker = Checker.new(client, @methods, indexes) + checker = Checker.new(client, @methods, indexe_names) checker.run end end @@ -69,10 +69,10 @@ module Groonga end class Checker < Runner - def initialize(client, methods, targets) + def initialize(client, methods, index_names) super(client) @methods = methods - @targets = targets + @index_names = index_names end private @@ -85,11 +85,11 @@ module Groonga end def check_target_table?(table_name) - unles****@targe***** > 0 + unless @index_names.count > 0 return true end - if****@targe*****_of?(Array) - @targets.each do |name| + if @index_names.kind_of?(Array) + @index_names.each do |name| table_part = name.split(".").first return true if table_name == table_part end @@ -98,15 +98,15 @@ module Groonga end def check_target_column?(column) - unles****@targe***** > 0 + unless @index_names.count > 0 return column["type"] == "index" else unless column["type"] == "index" return false end end - if****@targe*****_of?(Array) - @targets.each do |name| + if @index_names.kind_of?(Array) + @index_names.each do |name| return true if name == "#{column['domain']}.#{column['name']}" or name == column["domain"] end @@ -197,7 +197,7 @@ module Groonga end end if target_columns.empty? - abort_run("Failed to check <#{@targets.join(',')}> because there is no such a LEXCON.INDEX.") + abort_run("Failed to check <#{@index_names.join(',')}> because there is no such a LEXCON.INDEX.") end broken_indexes = [] target_columns.each do |column| -------------- next part -------------- HTML����������������������������... URL: https://lists.osdn.me/mailman/archives/groonga-commit/attachments/20171027/445e018b/attachment-0001.htm
